Remove some debugging code

Author: Dave Bartolomeo

.github/workflows/main.yml

@@ -273,10 +273,3 @@ jobs:
         if: matrix.os == 'windows-latest'
         run: |
           npm run test:cli-integration
-      
-      - name: Upload screenshots (Windows)
-        if: true
-        uses: actions/upload-artifact@v2
-        with:
-          name: screenshots
-          path: extensions/ql-vscode/*.png

extensions/ql-vscode/package.json

@@ -71,6 +71,7 @@
   "contributes": {
     "configurationDefaults": {
       "[ql]": {
+        "debug.saveBeforeStart": "nonUntitledEditorsInActiveGroup",
         "editor.wordBasedSuggestions": false
       },
       "[dbscheme]": {

extensions/ql-vscode/screenshot.bat

@@ -544,7 +544,7 @@ async function convertToQlPath(filePath: string): Promise<string> {
         }
       }
     }
-    throw new Error(`Can't convert path to form suitable for QL:${filePath}`);
+    throw new Error(`Can't convert path to form suitable for QL: ${filePath}`);
   } else {
     return filePath;
   }

extensions/ql-vscode/src/run-queries-shared.ts

@@ -153,10 +153,7 @@ describeWithCodeQL()("Debugger", () => {
   it("should save dirty documents before launching a debug session", async () => {
     await withDebugController(appCommands, async (controller) => {
       const editor = await selectForQuickEval(quickEvalLibPath, 4, 15, 4, 32);
-      await editor.edit((editBuilder) => {
-        editBuilder.insert(new Position(0, 0), "/* comment */");
-      });
-      expect(editor.document.isDirty).toBe(true);
+      expect(editor.document.isDirty).toBe(false);
 
       await controller.startDebuggingSelection({
         query: quickEvalQueryPath, // The query context. This query extends the abstract class.

extensions/ql-vscode/test/vscode-tests/cli-integration/debugger/debugger.test.ts

@@ -7,6 +7,8 @@ const {
   rootDir,
 } = require("../jest-runner-vscode.config.base");
 
+// Copy the workspace content to a temporary directory, and open it there. Some of our tests write
+// to files in the workspace, so we don't want to do that in the source directory.
 const tmpDataDir = path.join(tmpDir.name, "data");
 fs.cpSync(path.resolve(rootDir, "test/data"), tmpDataDir, {
   recursive: true,

extensions/ql-vscode/test/vscode-tests/cli-integration/jest-runner-vscode.config.js

@@ -8,7 +8,7 @@ const config: Config = {
   setupFilesAfterEnv: ["<rootDir>/jest.setup.ts"],
   // CLI integration tests call into the CLI and execute queries, so these are expected to take a lot longer
   // than the default 5 seconds.
-  testTimeout: 300_000, // 3 minutes
+  testTimeout: 180_000, // 3 minutes
 };
 
 export default config;