Skip to content

Commit dbd5d0f

Browse files
Remove unused arguments from resolveWebviewView
1 parent 54cf5c5 commit dbd5d0f

2 files changed

Lines changed: 5 additions & 23 deletions

File tree

extensions/ql-vscode/src/common/vscode/abstract-webview-view-provider.ts

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
1-
import type {
2-
CancellationToken,
3-
WebviewView,
4-
WebviewViewProvider,
5-
WebviewViewResolveContext,
6-
} from "vscode";
1+
import type { WebviewView, WebviewViewProvider } from "vscode";
72
import { Uri } from "vscode";
83
import type { WebviewKind, WebviewMessage } from "./webview-html";
94
import { getHtmlForWebview } from "./webview-html";
@@ -28,11 +23,7 @@ export abstract class AbstractWebviewViewProvider<
2823
* This is called when a view first becomes visible. This may happen when the view is
2924
* first loaded or when the user hides and then shows a view again.
3025
*/
31-
public resolveWebviewView(
32-
webviewView: WebviewView,
33-
_context: WebviewViewResolveContext,
34-
_token: CancellationToken,
35-
) {
26+
public resolveWebviewView(webviewView: WebviewView) {
3627
webviewView.webview.options = {
3728
enableScripts: true,
3829
localResourceRoots: [Uri.file(this.app.extensionPath)],

extensions/ql-vscode/test/vscode-tests/no-workspace/model-editor/method-modeling/method-modeling-view-provider.test.ts

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
1-
import type {
2-
Uri,
3-
Webview,
4-
WebviewView,
5-
WebviewViewResolveContext,
6-
} from "vscode";
7-
import { CancellationTokenSource, EventEmitter } from "vscode";
1+
import type { Uri, Webview, WebviewView } from "vscode";
2+
import { EventEmitter } from "vscode";
83
import type { ModelConfigListener } from "../../../../../src/config";
94
import { MethodModelingViewProvider } from "../../../../../src/model-editor/method-modeling/method-modeling-view-provider";
105
import { createMockApp } from "../../../../__mocks__/appMock";
@@ -88,11 +83,7 @@ describe("method modeling view provider", () => {
8883
onDidDispose: jest.fn(),
8984
});
9085

91-
viewProvider.resolveWebviewView(
92-
webviewView,
93-
mockedObject<WebviewViewResolveContext>({}),
94-
new CancellationTokenSource().token,
95-
);
86+
viewProvider.resolveWebviewView(webviewView);
9687

9788
expect(onDidReceiveMessage).toBeDefined();
9889
});

0 commit comments

Comments
 (0)