Skip to content

Commit dc3e1ce

Browse files
committed
Add script for updating Chromium version
1 parent e79f732 commit dc3e1ce

File tree

4 files changed

+49
-28
lines changed

4 files changed

+49
-28
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"chromiumVersion": "114",
3+
"electronVersion": "25.8.0"
4+
}

extensions/ql-vscode/gulpfile.ts/view.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ import esbuild from "gulp-esbuild";
33
import { createProject } from "gulp-typescript";
44
import { goodReporter } from "./typescript";
55

6+
import * as chromiumVersion from "./chromium-version.json";
7+
68
const tsProject = createProject("src/view/tsconfig.json");
79

810
export function compileViewEsbuild() {
@@ -13,7 +15,7 @@ export function compileViewEsbuild() {
1315
bundle: true,
1416
format: "iife",
1517
platform: "browser",
16-
target: "chrome114", // Electron 25, VS Code 1.85
18+
target: `chrome${chromiumVersion.chromiumVersion}`,
1719
jsx: "automatic",
1820
sourcemap: "linked",
1921
sourceRoot: "..",

extensions/ql-vscode/scripts/find-vscode-versions.ts

Lines changed: 0 additions & 27 deletions
This file was deleted.
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
import { join, resolve } from "path";
2+
import { outputFile, readJSON } from "fs-extra";
3+
import { minVersion } from "semver";
4+
import { getVersionInformation } from "./util/vscode-versions";
5+
6+
const extensionDirectory = resolve(__dirname, "..");
7+
8+
async function updateChromiumVersion() {
9+
const packageJson = await readJSON(
10+
resolve(extensionDirectory, "package.json"),
11+
);
12+
13+
const minimumVsCodeVersion = minVersion(packageJson.engines.vscode)?.version;
14+
if (!minimumVsCodeVersion) {
15+
throw new Error("Could not find minimum VS Code version");
16+
}
17+
18+
const versionInformation = await getVersionInformation(minimumVsCodeVersion);
19+
20+
const chromiumMajorVersion = versionInformation.chromiumVersion.split(".")[0];
21+
22+
console.log(
23+
`VS Code ${minimumVsCodeVersion} uses Chromium ${chromiumMajorVersion}`,
24+
);
25+
26+
await outputFile(
27+
join(extensionDirectory, "gulpfile.ts", "chromium-version.json"),
28+
`${JSON.stringify(
29+
{
30+
chromiumVersion: chromiumMajorVersion,
31+
electronVersion: versionInformation.electronVersion,
32+
},
33+
null,
34+
2,
35+
)}\n`,
36+
);
37+
}
38+
39+
updateChromiumVersion().catch((e: unknown) => {
40+
console.error(e);
41+
process.exit(2);
42+
});

0 commit comments

Comments
 (0)