Autofix @typescript-eslint/array-type

Author: elenatanasoiu

extensions/ql-vscode/.eslintrc.js

@@ -32,7 +32,6 @@ module.exports = {
         ignoreRestSiblings: false,
       },
     ],
-    "@typescript-eslint/array-type": "off",
     "@typescript-eslint/explicit-function-return-type": "off",
     "@typescript-eslint/explicit-module-boundary-types": "off",
     "@typescript-eslint/no-non-null-assertion": "off",

extensions/ql-vscode/src/abstract-webview.ts

@@ -32,7 +32,7 @@ export abstract class AbstractWebview<
 > extends DisposableObject {
   protected panel: WebviewPanel | undefined;
   protected panelLoaded = false;
-  protected panelLoadedCallBacks: (() => void)[] = [];
+  protected panelLoadedCallBacks: Array<() => void> = [];
 
   private panelResolves?: Array<(panel: WebviewPanel) => void>;
 

extensions/ql-vscode/src/archive-filesystem-provider.ts

@@ -209,7 +209,9 @@ export class ArchiveFileSystemProvider implements vscode.FileSystemProvider {
     return await this._lookup(uri);
   }
 
-  async readDirectory(uri: vscode.Uri): Promise<[string, vscode.FileType][]> {
+  async readDirectory(
+    uri: vscode.Uri,
+  ): Promise<Array<[string, vscode.FileType]>> {
     const ref = decodeSourceArchiveUri(uri);
     const archive = await this.getArchive(ref.sourceArchiveZipPath);
     const contents = archive.dirMap.get(ref.pathWithinSourceArchive);

extensions/ql-vscode/src/cli.ts

@@ -166,7 +166,7 @@ export class CodeQLCliServer implements Disposable {
   /** The process for the cli server, or undefined if one doesn't exist yet */
   process?: child_process.ChildProcessWithoutNullStreams;
   /** Queue of future commands*/
-  commandQueue: (() => void)[];
+  commandQueue: Array<() => void>;
   /** Whether a command is running */
   commandInProcess: boolean;
   /**  A buffer with a single null byte. */
@@ -915,7 +915,7 @@ export class CodeQLCliServer implements Disposable {
 
   // Warning: this function is untenable for large dot files,
   async readDotFiles(dir: string): Promise<string[]> {
-    const dotFiles: Promise<string>[] = [];
+    const dotFiles: Array<Promise<string>> = [];
     for await (const file of walkDirectory(dir)) {
       if (file.endsWith(".dot")) {
         dotFiles.push(fs.readFile(file, "utf8"));

extensions/ql-vscode/src/helpers.ts

@@ -460,7 +460,7 @@ export class CachedOperation<U> {
   private readonly lru: string[];
   private readonly inProgressCallbacks: Map<
     string,
-    [(u: U) => void, (reason?: any) => void][]
+    Array<[(u: U) => void, (reason?: any) => void]>
   >;
 
   constructor(
@@ -471,7 +471,7 @@ export class CachedOperation<U> {
     this.lru = [];
     this.inProgressCallbacks = new Map<
       string,
-      [(u: U) => void, (reason?: any) => void][]
+      Array<[(u: U) => void, (reason?: any) => void]>
     >();
     this.cached = new Map<string, U>();
   }
@@ -499,7 +499,7 @@ export class CachedOperation<U> {
     }
 
     // Otherwise compute the new value, but leave a callback to allow sharing work
-    const callbacks: [(u: U) => void, (reason?: any) => void][] = [];
+    const callbacks: Array<[(u: U) => void, (reason?: any) => void]> = [];
     this.inProgressCallbacks.set(t, callbacks);
     try {
       const result = await this.operation(t, ...args);

extensions/ql-vscode/src/interface.ts

@@ -825,7 +825,7 @@ export class ResultsView extends AbstractWebview<
       return;
     }
 
-    const diagnostics: [Uri, ReadonlyArray<Diagnostic>][] = [];
+    const diagnostics: Array<[Uri, readonly Diagnostic[]]> = [];
 
     for (const result of data.runs[0].results) {
       const message = result.message.text;

extensions/ql-vscode/src/legacy-query-server/queryserver-client.ts

@@ -47,7 +47,7 @@ export class QueryServerClient extends DisposableObject {
   nextProgress: number;
   withProgressReporting: WithProgressReporting;
 
-  private readonly queryServerStartListeners = [] as ProgressTask<void>[];
+  private readonly queryServerStartListeners = [] as Array<ProgressTask<void>>;
 
   // Can't use standard vscode EventEmitter here since they do not cause the calling
   // function to fail if one of the event handlers fail. This is something that

extensions/ql-vscode/src/log-insights/join-order.ts

@@ -149,7 +149,7 @@ class JoinOrderScanner implements EvaluationLogScanner {
   private readonly predicateSizes = new Map<string, number>();
   private readonly layerEvents = new Map<
     string,
-    (ComputeRecursive | InLayer)[]
+    Array<ComputeRecursive | InLayer>
   >();
   // Map a key of the form 'query-with-demand : predicate name' to its badness input.
   private readonly maxTupleCountMap = new Map<string, number[]>();

extensions/ql-vscode/src/query-server/queryserver-client.ts

@@ -44,7 +44,7 @@ export class QueryServerClient extends DisposableObject {
   nextProgress: number;
   withProgressReporting: WithProgressReporting;
 
-  private readonly queryServerStartListeners = [] as ProgressTask<void>[];
+  private readonly queryServerStartListeners = [] as Array<ProgressTask<void>>;
 
   // Can't use standard vscode EventEmitter here since they do not cause the calling
   // function to fail if one of the event handlers fail. This is something that

extensions/ql-vscode/src/remote-queries/analyses-results-manager.ts

@@ -112,7 +112,7 @@ export class AnalysesResultsManager {
       const taskResults = await Promise.allSettled(batchTasks);
       const failedTasks = taskResults.filter(
         (x) => x.status === "rejected",
-      ) as Array<PromiseRejectedResult>;
+      ) as PromiseRejectedResult[];
       if (failedTasks.length > 0) {
         const failures = failedTasks.map((t) => t.reason.message);
         failures.forEach((f) => void this.logger.log(f));