Merge pull request #3328 from github/robertbrignull/ref_types

Provide types for all react refs

Author: robertbrignull

extensions/ql-vscode/src/view/results/AlertTable.tsx

@@ -40,7 +40,7 @@ export function AlertTable({
     undefined,
   );
 
-  const selectedItemRef = useRef<any>();
+  const selectedItemRef = useRef<HTMLTableRowElement>(null);
   useScrollIntoView(selectedItem, selectedItemRef);
 
   /**

extensions/ql-vscode/src/view/results/AlertTablePathNodeRow.tsx

@@ -16,7 +16,7 @@ interface Props {
   pathIndex: number;
   resultIndex: number;
   selectedItem: undefined | ResultKey;
-  selectedItemRef: React.RefObject<any>;
+  selectedItemRef: React.RefObject<HTMLTableRowElement>;
   databaseUri: string;
   sourceLocationPrefix: string;
   updateSelectionCallback: (

extensions/ql-vscode/src/view/results/AlertTablePathRow.tsx

@@ -17,7 +17,7 @@ interface Props {
   resultIndex: number;
   currentPathExpanded: boolean;
   selectedItem: undefined | ResultKey;
-  selectedItemRef: React.RefObject<any>;
+  selectedItemRef: React.RefObject<HTMLTableRowElement>;
   databaseUri: string;
   sourceLocationPrefix: string;
   updateSelectionCallback: (

extensions/ql-vscode/src/view/results/AlertTableResultRow.tsx

@@ -18,7 +18,7 @@ interface Props {
   resultIndex: number;
   expanded: Set<string>;
   selectedItem: undefined | ResultKey;
-  selectedItemRef: React.RefObject<any>;
+  selectedItemRef: React.RefObject<HTMLTableRowElement>;
   databaseUri: string;
   sourceLocationPrefix: string;
   updateSelectionCallback: (

extensions/ql-vscode/src/view/results/RawTable.tsx

@@ -38,7 +38,7 @@ export function RawTable({
 }: RawTableProps) {
   const [selectedItem, setSelectedItem] = useState<TableItem | undefined>();
 
-  const selectedItemRef = useRef<any>();
+  const selectedItemRef = useRef<HTMLTableCellElement>(null);
   useScrollIntoView(selectedItem, selectedItemRef);
 
   const setSelection = useCallback((row: number, column: number): void => {

extensions/ql-vscode/src/view/results/RawTableRow.tsx

@@ -8,7 +8,7 @@ interface Props {
   databaseUri: string;
   className?: string;
   selectedColumn?: number;
-  selectedItemRef?: React.Ref<any>;
+  selectedItemRef?: React.Ref<HTMLTableCellElement>;
   onSelected?: (row: number, column: number) => void;
 }
 

extensions/ql-vscode/src/view/results/useScrollIntoView.tsx

@@ -3,10 +3,10 @@ import { useEffect } from "react";
 
 export function useScrollIntoView<T>(
   selectedElement: T | undefined,
-  selectedElementRef: RefObject<any>,
+  selectedElementRef: RefObject<HTMLElement>,
 ) {
   useEffect(() => {
-    const element = selectedElementRef.current as HTMLElement | undefined;
+    const element = selectedElementRef.current;
     if (!element) {
       return;
     }