Skip to content

Commit de8d0df

Browse files
Merge pull request #2671 from github/robertbrignull/sarif-parser-unit-test
Move sarif-parser.test.ts from no-workspace to unit-tests
2 parents 2b9aad3 + f7b07a0 commit de8d0df

File tree

6 files changed

+4
-10
lines changed

6 files changed

+4
-10
lines changed

extensions/ql-vscode/src/view/results/__tests__/results.spec.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,7 @@ import { ColumnKindCode } from "../../../common/bqrs-cli-types";
1212
import { postMessage } from "../../common/post-message";
1313

1414
const exampleSarif = fs.readJSONSync(
15-
resolve(
16-
__dirname,
17-
"../../../../test/vscode-tests/no-workspace/data/sarif/validSarif.sarif",
18-
),
15+
resolve(__dirname, "../../../../test/data/sarif/validSarif.sarif"),
1916
);
2017

2118
describe(ResultsApp.name, () => {

extensions/ql-vscode/test/vscode-tests/no-workspace/data/sarif/emptyResultsSarif.sarif renamed to extensions/ql-vscode/test/data/sarif/emptyResultsSarif.sarif

File renamed without changes.

extensions/ql-vscode/test/vscode-tests/no-workspace/data/sarif/invalidSarif.sarif renamed to extensions/ql-vscode/test/data/sarif/invalidSarif.sarif

File renamed without changes.

extensions/ql-vscode/test/vscode-tests/no-workspace/data/sarif/validSarif.sarif renamed to extensions/ql-vscode/test/data/sarif/validSarif.sarif

File renamed without changes.

extensions/ql-vscode/test/vscode-tests/no-workspace/common/sarif-parser.test.ts renamed to extensions/ql-vscode/test/unit-tests/common/sarif-parser.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { join } from "path";
22

3-
import { sarifParser } from "../../../../src/common/sarif-parser";
3+
import { sarifParser } from "../../../src/common/sarif-parser";
44

55
describe("sarif parser", () => {
6-
const sarifDir = join(__dirname, "../data/sarif");
6+
const sarifDir = join(__dirname, "../../data/sarif");
77
it("should parse a valid SARIF file", async () => {
88
const result = await sarifParser(join(sarifDir, "validSarif.sarif"));
99
expect(result.version).toBeDefined();

extensions/ql-vscode/test/vscode-tests/activated-extension/variant-analysis/variant-analysis-results-manager.test.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -279,10 +279,7 @@ describe(VariantAnalysisResultsManager.name, () => {
279279
await fs.outputJson(
280280
join(repoTaskStorageDirectory, "results/results.sarif"),
281281
await fs.readJson(
282-
resolve(
283-
__dirname,
284-
"../../no-workspace/data/sarif/validSarif.sarif",
285-
),
282+
resolve(__dirname, "../../../data/sarif/validSarif.sarif"),
286283
),
287284
);
288285
});

0 commit comments

Comments
 (0)