Merge pull request #2179 from github/robertbrignull/remove_openVariantAnalysisQueryFile_command

Remove codeQL.openVariantAnalysisQueryFile command

Author: robertbrignull

extensions/ql-vscode/src/extension.ts

@@ -1216,15 +1216,6 @@ async function activateWithInstalledDistribution(
     ),
   );
 
-  ctx.subscriptions.push(
-    commandRunner(
-      "codeQL.openVariantAnalysisQueryFile",
-      async (variantAnalysisId: number) => {
-        await variantAnalysisManager.openQueryFile(variantAnalysisId);
-      },
-    ),
-  );
-
   ctx.subscriptions.push(
     commandRunner("codeQL.openReferencedFile", async (selectedQuery: Uri) => {
       await openReferencedFile(qs, cliServer, selectedQuery);

extensions/ql-vscode/src/query-history/query-history-manager.ts

@@ -528,8 +528,7 @@ export class QueryHistoryManager extends DisposableObject {
     }
 
     if (finalSingleItem.t === "variant-analysis") {
-      await commands.executeCommand(
-        "codeQL.openVariantAnalysisQueryFile",
+      await this.variantAnalysisManager.openQueryFile(
         finalSingleItem.variantAnalysis.id,
       );
       return;

extensions/ql-vscode/src/variant-analysis/variant-analysis-view-manager.ts

@@ -24,4 +24,5 @@ export interface VariantAnalysisViewManager<
   getRepoStates(
     variantAnalysisId: number,
   ): Promise<VariantAnalysisScannedRepositoryState[]>;
+  openQueryFile(variantAnalysisId: number): Promise<void>;
 }

extensions/ql-vscode/src/variant-analysis/variant-analysis-view.ts

@@ -123,10 +123,7 @@ export class VariantAnalysisView
         );
         break;
       case "openQueryFile":
-        void commands.executeCommand(
-          "codeQL.openVariantAnalysisQueryFile",
-          this.variantAnalysisId,
-        );
+        await this.manager.openQueryFile(this.variantAnalysisId);
         break;
       case "openQueryText":
         void commands.executeCommand(

extensions/ql-vscode/src/view/variant-analysis/VariantAnalysis.tsx

@@ -13,7 +13,7 @@ import { VariantAnalysisLoading } from "./VariantAnalysisLoading";
 import { ToVariantAnalysisMessage } from "../../pure/interface-types";
 import { vscode } from "../vscode-api";
 import { defaultFilterSortState } from "../../pure/variant-analysis-filter-sort";
-import { useTelemetryOnChange } from "../common/telemetry";
+import { sendTelemetry, useTelemetryOnChange } from "../common/telemetry";
 
 export type VariantAnalysisProps = {
   variantAnalysis?: VariantAnalysisDomainModel;
@@ -25,6 +25,7 @@ const openQueryFile = () => {
   vscode.postMessage({
     t: "openQueryFile",
   });
+  sendTelemetry("variant-analysis-open-query-file");
 };
 
 const openQueryText = () => {