Add row showing how many methods are hidden

Author: robertbrignull

extensions/ql-vscode/src/view/model-editor/HiddenMethodsRow.tsx

@@ -0,0 +1,30 @@
+import {
+  VSCodeDataGridCell,
+  VSCodeDataGridRow,
+} from "@vscode/webview-ui-toolkit/react";
+import * as React from "react";
+import { styled } from "styled-components";
+
+const HiddenMethodsCell = styled(VSCodeDataGridCell)`
+  text-align: center;
+`;
+
+interface Props {
+  numHiddenMethods: number;
+  someMethodsAreVisible: boolean;
+}
+
+export function HiddenMethodsRow(props: Props) {
+  if (props.numHiddenMethods === 0) {
+    return null;
+  }
+
+  return (
+    <VSCodeDataGridRow>
+      <HiddenMethodsCell gridColumn="span 5">
+        {props.someMethodsAreVisible && "And "}
+        {props.numHiddenMethods} methods modeled in other CodeQL packs
+      </HiddenMethodsCell>
+    </VSCodeDataGridRow>
+  );
+}

extensions/ql-vscode/src/view/model-editor/ModeledMethodDataGrid.tsx

@@ -11,6 +11,7 @@ import { useMemo } from "react";
 import { Mode } from "../../model-editor/shared/mode";
 import { sortMethods } from "../../model-editor/shared/sorting";
 import { InProgressMethods } from "../../model-editor/shared/in-progress-methods";
+import { HiddenMethodsRow } from "./HiddenMethodsRow";
 
 export const GRID_TEMPLATE_COLUMNS = "0.5fr 0.125fr 0.125fr 0.125fr 0.125fr";
 
@@ -35,11 +36,12 @@ export const ModeledMethodDataGrid = ({
   hideModeledApis,
   onChange,
 }: Props) => {
-  const methodsWithModelability: Array<{
-    method: Method;
-    methodCanBeModeled: boolean;
-  }> = useMemo(() => {
+  const [methodsWithModelability, numHiddenMethods]: [
+    Array<{ method: Method; methodCanBeModeled: boolean }>,
+    number,
+  ] = useMemo(() => {
     const methodsWithModelability = [];
+    let numHiddenMethods = 0;
     for (const method of sortMethods(methods)) {
       const modeledMethod = modeledMethods[method.signature];
       const methodIsUnsaved = modifiedSignatures.has(method.signature);
@@ -50,9 +52,11 @@ export const ModeledMethodDataGrid = ({
 
       if (methodCanBeModeled || !hideModeledApis) {
         methodsWithModelability.push({ method, methodCanBeModeled });
+      } else {
+        numHiddenMethods += 1;
       }
     }
-    return methodsWithModelability;
+    return [methodsWithModelability, numHiddenMethods];
   }, [hideModeledApis, methods, modeledMethods, modifiedSignatures]);
 
   const someMethodsAreVisible = methodsWithModelability.length > 0;
@@ -95,6 +99,10 @@ export const ModeledMethodDataGrid = ({
           ))}
         </>
       )}
+      <HiddenMethodsRow
+        numHiddenMethods={numHiddenMethods}
+        someMethodsAreVisible={someMethodsAreVisible}
+      />
     </VSCodeDataGrid>
   );
 };