Merge pull request #1540 from github/aeisenberg/safe-max-fix

Ensure `safeMax` is safe for undefined values

Author: aeisenberg

extensions/ql-vscode/src/log-insights/join-order.ts

@@ -7,8 +7,8 @@ const DEFAULT_WARNING_THRESHOLD = 50;
 /**
  * Like `max`, but returns 0 if no meaningful maximum can be computed.
  */
-function safeMax(it: Iterable<number>) {
-  const m = Math.max(...it);
+function safeMax(it?: Iterable<number>) {
+  const m = Math.max(...(it || []));
   return Number.isFinite(m) ? m : 0;
 }