Skip to content

Commit e6b1d8d

Browse files
committed
Fix isQuickEvalCount logic
Since `false !== undefined` evaluates to true, we would assign the wrong value to `isQuickEvalCount` when `selectedQuery.quickEval?.quickEvalCount` is false
1 parent ad9f78c commit e6b1d8d

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

extensions/ql-vscode/src/run-queries-shared.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -495,8 +495,7 @@ export async function createInitialQueryInfo(
495495
outputDir: QueryOutputDir,
496496
): Promise<InitialQueryInfo> {
497497
const isQuickEval = selectedQuery.quickEval !== undefined;
498-
const isQuickEvalCount =
499-
selectedQuery.quickEval?.quickEvalCount !== undefined;
498+
const isQuickEvalCount = Boolean(selectedQuery.quickEval?.quickEvalCount);
500499
return {
501500
queryPath: selectedQuery.queryPath,
502501
isQuickEval,

0 commit comments

Comments
 (0)