Skip to content

Commit e74a2e4

Browse files
committed
Remove UIService
This class seems to have been introduced at some point to reduce the dependency on VS Code from the test UI service. However, none of its methods are being used anymore, and by using typed commands we have already reduced the dependency on VS Code. Therefore, we can simply remove this class.
1 parent 9f85f56 commit e74a2e4

File tree

2 files changed

+1
-34
lines changed

2 files changed

+1
-34
lines changed

extensions/ql-vscode/src/test-ui.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import {
1414
import { showAndLogWarningMessage } from "./helpers";
1515
import { TestTreeNode } from "./test-tree-node";
1616
import { DisposableObject } from "./pure/disposable-object";
17-
import { UIService } from "./vscode-utils/ui-service";
1817
import { QLTestAdapter, getExpectedFile, getActualFile } from "./test-adapter";
1918
import { TestUICommands } from "./common/commands";
2019

@@ -42,7 +41,7 @@ class QLTestListener extends DisposableObject {
4241
/**
4342
* Service that implements all UI and commands for QL tests.
4443
*/
45-
export class TestUIService extends UIService implements TestController {
44+
export class TestUIService extends DisposableObject implements TestController {
4645
private readonly listeners: Map<TestAdapter, QLTestListener> = new Map();
4746

4847
constructor(private readonly testHub: TestHub) {

extensions/ql-vscode/src/vscode-utils/ui-service.ts

Lines changed: 0 additions & 32 deletions
This file was deleted.

0 commit comments

Comments
 (0)