Skip to content

Commit e7c79f0

Browse files
committed
Remove dead code
1 parent 7652957 commit e7c79f0

5 files changed

Lines changed: 9 additions & 42 deletions

File tree

extensions/ql-vscode/src/common/bqrs-cli-types.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export type ColumnKind =
2121
| typeof ColumnKindCode.DATE
2222
| typeof ColumnKindCode.ENTITY;
2323

24-
export interface Column {
24+
interface Column {
2525
name?: string;
2626
kind: ColumnKind;
2727
}
@@ -77,19 +77,12 @@ export interface WholeFileLocation {
7777
endColumn: never;
7878
}
7979

80-
export type ResolvableLocationValue = WholeFileLocation | LineColumnLocation;
80+
type ResolvableLocationValue = WholeFileLocation | LineColumnLocation;
8181

8282
export type UrlValue = ResolvableLocationValue | string;
8383

8484
export type CellValue = EntityValue | number | string | boolean;
8585

86-
export type ResultRow = CellValue[];
87-
88-
export interface RawResultSet {
89-
readonly schema: ResultSetSchema;
90-
readonly rows: readonly ResultRow[];
91-
}
92-
9386
export type BqrsKind =
9487
| "String"
9588
| "Float"

extensions/ql-vscode/src/common/bqrs-utils.ts

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
import { createRemoteFileRef } from "../common/location-link-utils";
22
import { isUrlValueResolvable, UrlValue } from "./raw-result-types";
3-
import {
4-
LineColumnLocation,
5-
UrlValue as BqrsUrlValue,
6-
WholeFileLocation,
7-
} from "./bqrs-cli-types";
83

94
/**
105
* Checks whether the file path is empty. If so, we do not want to render this location
@@ -14,27 +9,6 @@ export function isEmptyPath(uriStr: string) {
149
return !uriStr || uriStr === "file:/";
1510
}
1611

17-
export function isLineColumnLoc(loc: BqrsUrlValue): loc is LineColumnLocation {
18-
return (
19-
typeof loc !== "string" &&
20-
!isEmptyPath(loc.uri) &&
21-
"startLine" in loc &&
22-
"startColumn" in loc &&
23-
"endLine" in loc &&
24-
"endColumn" in loc
25-
);
26-
}
27-
28-
export function isWholeFileLoc(loc: BqrsUrlValue): loc is WholeFileLocation {
29-
return (
30-
typeof loc !== "string" && !isEmptyPath(loc.uri) && !isLineColumnLoc(loc)
31-
);
32-
}
33-
34-
export function isStringLoc(loc: BqrsUrlValue): loc is string {
35-
return typeof loc === "string";
36-
}
37-
3812
export function tryGetRemoteLocation(
3913
loc: UrlValue | undefined,
4014
fileLinkPrefix: string,

extensions/ql-vscode/src/common/interface-types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export const SELECT_TABLE_NAME = "#select";
3535
export const ALERTS_TABLE_NAME = "alerts";
3636
export const GRAPH_TABLE_NAME = "graph";
3737

38-
export type RawTableResultSet = {
38+
type RawTableResultSet = {
3939
t: "RawResultSet";
4040
resultSet: RawResultSet;
4141
};

extensions/ql-vscode/src/common/raw-result-types.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export type Column = {
1212
kind: ColumnKind;
1313
};
1414

15-
export type UrlValueString = {
15+
type UrlValueString = {
1616
type: "string";
1717
value: string;
1818
};
@@ -51,22 +51,22 @@ export type EntityValue = {
5151
id?: number;
5252
};
5353

54-
export type CellValueEntity = {
54+
type CellValueEntity = {
5555
type: "entity";
5656
value: EntityValue;
5757
};
5858

59-
export type CellValueNumber = {
59+
type CellValueNumber = {
6060
type: "number";
6161
value: number;
6262
};
6363

64-
export type CellValueString = {
64+
type CellValueString = {
6565
type: "string";
6666
value: string;
6767
};
6868

69-
export type CellValueBoolean = {
69+
type CellValueBoolean = {
7070
type: "boolean";
7171
value: boolean;
7272
};

extensions/ql-vscode/src/model-editor/method.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { ModeledMethod, ModeledMethodType } from "./modeled-method";
22
import { UrlValueResolvable } from "../common/raw-result-types";
33

4-
export type Call = {
4+
type Call = {
55
readonly label: string;
66
readonly url: Readonly<UrlValueResolvable>;
77
};

0 commit comments

Comments
 (0)