Skip to content

Commit eaf81ef

Browse files
Extract nested ternary to method
1 parent 9da3dc9 commit eaf81ef

1 file changed

Lines changed: 18 additions & 7 deletions

File tree

extensions/ql-vscode/src/view/model-editor/MethodRow.tsx

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -104,13 +104,8 @@ const ModelableMethodRow = forwardRef<HTMLElement | undefined, MethodRowProps>(
104104
} = props;
105105

106106
const modeledMethods: Array<ModeledMethod | undefined> = useMemo(
107-
() =>
108-
modeledMethodsProp.length === 0
109-
? [undefined]
110-
: viewState.showMultipleModels
111-
? modeledMethodsProp
112-
: modeledMethodsProp.slice(0, 1),
113-
[modeledMethodsProp, viewState],
107+
() => modeledMethodsToDisplay(modeledMethodsProp, method, viewState),
108+
[modeledMethodsProp, method, viewState],
114109
);
115110

116111
const modeledMethodChangedHandlers = useMemo(
@@ -265,3 +260,19 @@ function sendJumpToMethodMessage(method: Method) {
265260
methodSignature: method.signature,
266261
});
267262
}
263+
264+
function modeledMethodsToDisplay(
265+
modeledMethods: ModeledMethod[],
266+
method: Method,
267+
viewState: ModelEditorViewState,
268+
): Array<ModeledMethod | undefined> {
269+
if (modeledMethods.length === 0) {
270+
return [undefined];
271+
}
272+
273+
if (viewState.showMultipleModels) {
274+
return modeledMethods;
275+
} else {
276+
return modeledMethods.slice(0, 1);
277+
}
278+
}

0 commit comments

Comments
 (0)