Fix lint violations

Author: jcreedcmu

extensions/ql-vscode/src/bqrs-cli-types.ts

@@ -6,6 +6,7 @@ export const PAGE_SIZE = 1000;
  * of a result column. This namespace is intentionally not an enum, see
  * the "for the sake of extensibility" comment in messages.ts.
  */
+// eslint-disable-next-line @typescript-eslint/no-namespace
 export namespace ColumnKindCode {
   export const FLOAT = "f";
   export const INTEGER = "i";

extensions/ql-vscode/src/definitions.ts

@@ -74,7 +74,7 @@ export class TemplateQueryDefinitionProvider implements vscode.DefinitionProvide
 
   async provideDefinition(document: vscode.TextDocument, position: vscode.Position, _token: vscode.CancellationToken): Promise<vscode.LocationLink[]> {
     const fileLinks = await this.cache.get(document.uri.toString());
-    let locLinks: vscode.LocationLink[] = [];
+    const locLinks: vscode.LocationLink[] = [];
     for (const link of fileLinks) {
       if (link.originSelectionRange!.contains(position)) {
         locLinks.push(link);
@@ -101,7 +101,7 @@ export class TemplateQueryReferenceProvider implements vscode.ReferenceProvider
 
   async provideReferences(document: vscode.TextDocument, position: vscode.Position, _context: vscode.ReferenceContext, _token: vscode.CancellationToken): Promise<vscode.Location[]> {
     const fileLinks = await this.cache.get(document.uri.toString());
-    let locLinks: vscode.Location[] = [];
+    const locLinks: vscode.Location[] = [];
     for (const link of fileLinks) {
       if (link.targetRange!.contains(position)) {
         locLinks.push({ range: link.originSelectionRange!, uri: link.originUri });
@@ -112,8 +112,8 @@ export class TemplateQueryReferenceProvider implements vscode.ReferenceProvider
 }
 
 interface FileRange {
-  file: vscode.Uri,
-  range: vscode.Range
+  file: vscode.Uri;
+  range: vscode.Range;
 }
 
 async function getLinksFromResults(results: QueryWithResults, cli: CodeQLCliServer, db: DatabaseItem, filter: (srcFile: string, destFile: string) => boolean): Promise<FullLocationLink[]> {

extensions/ql-vscode/src/discovery.ts

@@ -84,4 +84,4 @@ export abstract class Discovery<T> extends DisposableObject {
    * @param results The discovery results returned by the `discover` function.
    */
   protected abstract update(results: T): void;
-}
+}

extensions/ql-vscode/src/logging.ts

@@ -60,7 +60,7 @@ export class OutputChannelLogger extends DisposableObject implements Logger {
    * function if you don't need to guarantee that the log writing is complete before
    * continuing.
    */
-  async log(message: string, options = { } as LogOptions): Promise<void> {
+  async log(message: string, options = {} as LogOptions): Promise<void> {
     if (options.trailingNewline === undefined) {
       options.trailingNewline = true;
     }
@@ -116,7 +116,7 @@ class AdditionalLogLocation extends Disposable {
     super(() => { /**/ });
   }
 
-  async log(message: string, options = { } as LogOptions): Promise<void> {
+  async log(message: string, options = {} as LogOptions): Promise<void> {
     if (options.trailingNewline === undefined) {
       options.trailingNewline = true;
     }