Skip to content

Commit ef8bf9f

Browse files
authored
Merge pull request #3154 from github/koesie10/source-map-fix
Switch to `yauzl` for source map script
2 parents f736adc + 0dcc814 commit ef8bf9f

3 files changed

Lines changed: 8 additions & 132 deletions

File tree

extensions/ql-vscode/package-lock.json

Lines changed: 5 additions & 128 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extensions/ql-vscode/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1940,7 +1940,6 @@
19401940
"tmp": "^0.2.1",
19411941
"tmp-promise": "^3.0.2",
19421942
"tree-kill": "^1.2.2",
1943-
"unzipper": "^0.10.5",
19441943
"vscode-extension-telemetry": "^0.1.6",
19451944
"vscode-jsonrpc": "^8.0.2",
19461945
"vscode-languageclient": "^8.0.2",

extensions/ql-vscode/scripts/source-map.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import { spawnSync } from "child_process";
2020
import { basename, resolve } from "path";
2121
import { pathExists, readJSON } from "fs-extra";
2222
import { RawSourceMap, SourceMapConsumer } from "source-map";
23-
import { Open } from "unzipper";
23+
import { unzipToDirectory } from "../src/common/unzip";
2424

2525
if (process.argv.length !== 4) {
2626
console.error(
@@ -78,10 +78,10 @@ async function extractSourceMap() {
7878
releaseAssetsDirectory,
7979
]);
8080

81-
const file = await Open.file(
81+
await unzipToDirectory(
8282
resolve(releaseAssetsDirectory, sourcemapAsset.name),
83+
sourceMapsDirectory,
8384
);
84-
await file.extract({ path: sourceMapsDirectory });
8585
} else {
8686
const workflowRuns = runGhJSON<WorkflowRunListItem[]>([
8787
"run",

0 commit comments

Comments
 (0)