Write correct value to setting

Author: elenatanasoiu

extensions/ql-vscode/src/databases/local-databases.ts

@@ -746,7 +746,7 @@ export class DatabaseManager extends DisposableObject {
       return;
     }
 
-    if (getAutogenerateQlPacks() === "No, and never ask me again") {
+    if (getAutogenerateQlPacks() === "never") {
       return;
     }
 
@@ -759,7 +759,7 @@ export class DatabaseManager extends DisposableObject {
     }
 
     if (answer === "No, and never ask me again") {
-      await setAutogenerateQlPacks("No, and never ask me again");
+      await setAutogenerateQlPacks("never");
       return;
     }
 

extensions/ql-vscode/test/vscode-tests/minimal-workspace/local-databases.test.ts

@@ -685,10 +685,7 @@ describe("local databases", () => {
         await (databaseManager as any).createSkeletonPacks(mockDbItem);
 
         expect(generateSpy).not.toBeCalled();
-        expect(updateValueSpy).toHaveBeenCalledWith(
-          "No, and never ask me again",
-          1,
-        );
+        expect(updateValueSpy).toHaveBeenCalledWith("never", 1);
       });
 
       it("should create the skeleton QL pack for the user", async () => {