Skip to content

Commit f11cd17

Browse files
committed
Check these when query starts instead of completes
1 parent eddc228 commit f11cd17

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

extensions/ql-vscode/docs/test-plan.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,14 @@ choose to go through some of the Optional Test Cases.
3535
4. Check the query history. It should:
3636
- Show that an item has been added to the query history
3737
- The item should be marked as “in progress”.
38-
5. Once the query completes:
39-
- Check that a notification is shown with a link to the results view
38+
5. Once the query starts:
4039
- Check the results view
4140
- Check the code paths view, including the code paths drop down menu.
4241
- Check that the repository filter box works
43-
- Click links to files/locations on GitHub.
42+
- Click links to files/locations on GitHub
43+
- Check that the query history item is updated to show the number of results
44+
6. Once the query completes:
45+
- Check that the query history item is updated to show the query status as "complete"
4446

4547
### Test Case 2: MRVA - Running a problem query and viewing results
4648

@@ -52,7 +54,7 @@ choose to go through some of the Optional Test Cases.
5254
4. Check the query history. It should:
5355
- Show that an item has been added to the query history
5456
- The item should be marked as “in progress”.
55-
5. Once the query completes:
57+
5. Once the query starts:
5658
- Check that a notification is shown with a link to the results view
5759
- Check that the results are rendered with an alert message and a highlighted code snippet:
5860
![highlighted-code-snippet](images/highlighted-code-snippet.png)
@@ -61,7 +63,7 @@ choose to go through some of the Optional Test Cases.
6163

6264
1. Open the [FunLinesOfCode query](https://github.com/github/codeql/blob/main/cpp/ql/src/Metrics/Functions/FunLinesOfCode.ql).
6365
2. Run it against a single repository (e.g. `google/brotli`).
64-
3. Once the query is complete:
66+
3. Once the query starts:
6567
- Open the query results
6668
- Check that the results show up in a table:
6769
![results-table](images/results-table.png)

0 commit comments

Comments
 (0)