Skip to content

Commit f1dbc22

Browse files
output telemtry from local results view on state changes
1 parent 1077675 commit f1dbc22

3 files changed

Lines changed: 19 additions & 0 deletions

File tree

extensions/ql-vscode/src/view/results/alert-table.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import {
3030
import { vscode } from "../vscode-api";
3131
import { isWholeFileLoc, isLineColumnLoc } from "../../pure/bqrs-utils";
3232
import { ScrollIntoViewHelper } from "./scroll-into-view-helper";
33+
import { sendTelemetry } from "../common/telemetry";
3334

3435
export type PathTableProps = ResultTableProps & {
3536
resultSet: InterpretedResultSet<SarifInterpretationData>;
@@ -64,6 +65,9 @@ export class PathTable extends React.Component<PathTableProps, PathTableState> {
6465
expanded.add(str);
6566
}
6667
}
68+
if (expanded) {
69+
sendTelemetry("local-results-alert-table-path-expanded");
70+
}
6771
return { expanded };
6872
});
6973
e.stopPropagation();
@@ -185,6 +189,7 @@ export class PathTable extends React.Component<PathTableProps, PathTableState> {
185189
...previousState,
186190
selectedItem: resultKey,
187191
}));
192+
sendTelemetry("local-results-alert-table-path-selected");
188193
};
189194
};
190195

extensions/ql-vscode/src/view/results/raw-results-table.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import { ResultRow } from "../../pure/bqrs-cli-types";
1818
import { onNavigation } from "./results";
1919
import { tryGetResolvableLocation } from "../../pure/bqrs-utils";
2020
import { ScrollIntoViewHelper } from "./scroll-into-view-helper";
21+
import { sendTelemetry } from "../common/telemetry";
2122

2223
export type RawTableProps = ResultTableProps & {
2324
resultSet: RawTableResultSet;
@@ -44,6 +45,7 @@ export class RawTable extends React.Component<RawTableProps, RawTableState> {
4445
...prev,
4546
selectedItem: { row, column },
4647
}));
48+
sendTelemetry("local-results-raw-results-table-selected");
4749
}
4850

4951
render(): React.ReactNode {

extensions/ql-vscode/src/view/results/result-tables.tsx

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import {
2626
openFile,
2727
} from "./result-table-utils";
2828
import { vscode } from "../vscode-api";
29+
import { sendTelemetry } from "../common/telemetry";
2930

3031
const FILE_PATH_REGEX = /^(?:.+[\\/])*(.+)$/;
3132

@@ -165,6 +166,9 @@ export class ResultTables extends React.Component<
165166
this.setState({
166167
problemsViewSelected: e.target.checked,
167168
});
169+
if (e.target.checked) {
170+
sendTelemetry("local-results-show-results-in-problems-view");
171+
}
168172
if (resultsPath !== undefined) {
169173
vscode.postMessage({
170174
t: "toggleDiagnostics",
@@ -199,6 +203,10 @@ export class ResultTables extends React.Component<
199203
return parsedResultSets.pageNumber * parsedResultSets.pageSize;
200204
}
201205

206+
sendResultsPageChangedTelemetry() {
207+
sendTelemetry("local-results-alert-table-page-changed");
208+
}
209+
202210
renderPageButtons(): JSX.Element {
203211
const { parsedResultSets } = this.props;
204212
const selectedTable = this.state.selectedTable;
@@ -217,6 +225,7 @@ export class ResultTables extends React.Component<
217225

218226
const onChange = (e: React.ChangeEvent<HTMLInputElement>) => {
219227
this.setState({ selectedPage: e.target.value });
228+
this.sendResultsPageChangedTelemetry();
220229
};
221230
const choosePage = (input: string) => {
222231
const pageNumber = parseInt(input);
@@ -239,13 +248,15 @@ export class ResultTables extends React.Component<
239248
pageNumber: Math.max(parsedResultSets.pageNumber - 1, 0),
240249
selectedTable,
241250
});
251+
this.sendResultsPageChangedTelemetry();
242252
};
243253
const nextPage = (e: React.MouseEvent<HTMLButtonElement, MouseEvent>) => {
244254
vscode.postMessage({
245255
t: "changePage",
246256
pageNumber: Math.min(parsedResultSets.pageNumber + 1, numPages - 1),
247257
selectedTable,
248258
});
259+
this.sendResultsPageChangedTelemetry();
249260
};
250261

251262
const openQuery = () => {
@@ -334,6 +345,7 @@ export class ResultTables extends React.Component<
334345
nonemptyRawResults={nonemptyRawResults}
335346
showRawResults={() => {
336347
this.setState({ selectedTable: SELECT_TABLE_NAME });
348+
sendTelemetry("local-results-show-raw-results");
337349
}}
338350
offset={this.getOffset()}
339351
/>

0 commit comments

Comments
 (0)