Use more standard name for callback

Author: robertbrignull

extensions/ql-vscode/src/view/results/RawTableValue.tsx

@@ -24,7 +24,7 @@ export default function RawTableValue(props: Props): JSX.Element {
       loc={rawValue.url}
       label={rawValue.label}
       databaseUri={props.databaseUri}
-      jumpToLocationCallback={props.onSelected}
+      handleClick={props.onSelected}
     />
   );
 }

extensions/ql-vscode/src/view/results/alert-table.tsx

@@ -130,7 +130,7 @@ export class AlertTable extends React.Component<
               relatedLocations={result.relatedLocations}
               sourceLocationPrefix={sourceLocationPrefix}
               databaseUri={databaseUri}
-              jumpToLocationCallback={updateSelectionCallback(resultKey)}
+              handleClick={updateSelectionCallback(resultKey)}
             />
           );
 
@@ -144,7 +144,7 @@ export class AlertTable extends React.Component<
               loc={result.locations[0]}
               sourceLocationPrefix={sourceLocationPrefix}
               databaseUri={databaseUri}
-              jumpToLocationCallback={updateSelectionCallback(resultKey)}
+              handleClick={updateSelectionCallback(resultKey)}
             />
           );
         const locationCells = (
@@ -262,9 +262,7 @@ export class AlertTable extends React.Component<
                       loc={step.location}
                       sourceLocationPrefix={sourceLocationPrefix}
                       databaseUri={databaseUri}
-                      jumpToLocationCallback={updateSelectionCallback(
-                        pathNodeKey,
-                      )}
+                      handleClick={updateSelectionCallback(pathNodeKey)}
                     />
                   ) : (
                     "[no location]"
@@ -275,9 +273,7 @@ export class AlertTable extends React.Component<
                       loc={step.location}
                       sourceLocationPrefix={sourceLocationPrefix}
                       databaseUri={databaseUri}
-                      jumpToLocationCallback={updateSelectionCallback(
-                        pathNodeKey,
-                      )}
+                      handleClick={updateSelectionCallback(pathNodeKey)}
                     />
                   ) : (
                     ""

extensions/ql-vscode/src/view/results/locations/ClickableLocation.tsx

@@ -8,7 +8,7 @@ interface Props {
   label: string;
   databaseUri: string;
   title?: string;
-  jumpToLocationCallback?: () => void;
+  handleClick?: () => void;
 }
 
 /**
@@ -19,16 +19,16 @@ export function ClickableLocation({
   label,
   databaseUri,
   title,
-  jumpToLocationCallback,
+  handleClick,
 }: Props): JSX.Element {
   const jumpToLocationHandler = useCallback(
     (e: React.MouseEvent) => {
       e.preventDefault();
       e.stopPropagation();
       jumpToLocation(loc, databaseUri);
-      jumpToLocationCallback?.();
+      handleClick?.();
     },
-    [loc, databaseUri, jumpToLocationCallback],
+    [loc, databaseUri, handleClick],
   );
 
   return (

extensions/ql-vscode/src/view/results/locations/Location.tsx

@@ -15,7 +15,7 @@ interface Props {
   label?: string;
   databaseUri?: string;
   title?: string;
-  jumpToLocationCallback?: () => void;
+  handleClick?: () => void;
 }
 
 /**
@@ -26,7 +26,7 @@ export function Location({
   label,
   databaseUri,
   title,
-  jumpToLocationCallback,
+  handleClick,
 }: Props): JSX.Element {
   const resolvableLoc = useMemo(() => tryGetResolvableLocation(loc), [loc]);
   const displayLabel = useMemo(() => convertNonPrintableChars(label!), [label]);
@@ -43,7 +43,7 @@ export function Location({
         label={displayLabel}
         databaseUri={databaseUri}
         title={title}
-        jumpToLocationCallback={jumpToLocationCallback}
+        handleClick={handleClick}
       />
     );
   }

extensions/ql-vscode/src/view/results/locations/SarifLocation.tsx

@@ -11,7 +11,7 @@ interface Props {
   loc?: Sarif.Location;
   sourceLocationPrefix: string;
   databaseUri: string;
-  jumpToLocationCallback: () => void;
+  handleClick: () => void;
 }
 
 /**
@@ -25,7 +25,7 @@ export function SarifLocation({
   loc,
   sourceLocationPrefix,
   databaseUri,
-  jumpToLocationCallback,
+  handleClick,
 }: Props) {
   const parsedLoc = useMemo(
     () => loc && parseSarifLocation(loc, sourceLocationPrefix),
@@ -40,7 +40,7 @@ export function SarifLocation({
         label={text || `${basename(parsedLoc.userVisibleFile)}`}
         databaseUri={databaseUri}
         title={text ? undefined : `${parsedLoc.userVisibleFile}`}
-        jumpToLocationCallback={jumpToLocationCallback}
+        handleClick={handleClick}
       />
     );
   } else if (isLineColumnLoc(parsedLoc)) {
@@ -55,7 +55,7 @@ export function SarifLocation({
         }
         databaseUri={databaseUri}
         title={text ? undefined : `${parsedLoc.userVisibleFile}`}
-        jumpToLocationCallback={jumpToLocationCallback}
+        handleClick={handleClick}
       />
     );
   } else {

extensions/ql-vscode/src/view/results/locations/SarifMessageWithLocations.tsx

@@ -8,7 +8,7 @@ interface Props {
   relatedLocations: Sarif.Location[];
   sourceLocationPrefix: string;
   databaseUri: string;
-  jumpToLocationCallback: () => void;
+  handleClick: () => void;
 }
 
 /**
@@ -19,7 +19,7 @@ export function SarifMessageWithLocations({
   relatedLocations,
   sourceLocationPrefix,
   databaseUri,
-  jumpToLocationCallback,
+  handleClick,
 }: Props) {
   const relatedLocationsById: Map<number, Sarif.Location> = new Map();
   for (const loc of relatedLocations) {
@@ -41,7 +41,7 @@ export function SarifMessageWithLocations({
               loc={relatedLocationsById.get(part.dest)}
               sourceLocationPrefix={sourceLocationPrefix}
               databaseUri={databaseUri}
-              jumpToLocationCallback={jumpToLocationCallback}
+              handleClick={handleClick}
             />
           );
         }