Skip to content

Commit f559b59

Browse files
authored
Merge pull request #1420 from github/robertbrignull/api-retry
Add API retries for octokit requests
2 parents c9d895e + 825054a commit f559b59

File tree

3 files changed

+34
-2
lines changed

3 files changed

+34
-2
lines changed

extensions/ql-vscode/package-lock.json

Lines changed: 29 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extensions/ql-vscode/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1144,6 +1144,7 @@
11441144
},
11451145
"dependencies": {
11461146
"@octokit/rest": "^18.5.6",
1147+
"@octokit/plugin-retry": "^3.0.9",
11471148
"@primer/octicons-react": "^16.3.0",
11481149
"@primer/react": "^35.0.0",
11491150
"@vscode/webview-ui-toolkit": "^1.0.0",

extensions/ql-vscode/src/authentication.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import * as vscode from 'vscode';
22
import * as Octokit from '@octokit/rest';
3+
import { retry } from '@octokit/plugin-retry';
34

45
const GITHUB_AUTH_PROVIDER_ID = 'github';
56

@@ -51,14 +52,15 @@ export class Credentials {
5152

5253
private async createOctokit(createIfNone: boolean, overrideToken?: string): Promise<Octokit.Octokit | undefined> {
5354
if (overrideToken) {
54-
return new Octokit.Octokit({ auth: overrideToken });
55+
return new Octokit.Octokit({ auth: overrideToken, retry });
5556
}
5657

5758
const session = await vscode.authentication.getSession(GITHUB_AUTH_PROVIDER_ID, SCOPES, { createIfNone });
5859

5960
if (session) {
6061
return new Octokit.Octokit({
61-
auth: session.accessToken
62+
auth: session.accessToken,
63+
retry
6264
});
6365
} else {
6466
return undefined;

0 commit comments

Comments
 (0)