Skip to content

Commit f927ac9

Browse files
Split out MethodSignature from ExternalApiUsage
1 parent 31fdc79 commit f927ac9

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

extensions/ql-vscode/src/data-extensions-editor/external-api-usage.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,7 @@ export type Call = {
55
url: ResolvableLocationValue;
66
};
77

8-
export type ExternalApiUsage = {
9-
/**
10-
* Contains the name of the library containing the method declaration, e.g. `sql2o-1.6.0.jar` or `System.Runtime.dll`
11-
*/
12-
library: string;
8+
export interface MethodSignature {
139
/**
1410
* A unique signature that can be used to identify this external API usage.
1511
*
@@ -25,10 +21,17 @@ export type ExternalApiUsage = {
2521
* The method parameters, including enclosing parentheses, e.g. `(String, String)`
2622
*/
2723
methodParameters: string;
24+
}
25+
26+
export interface ExternalApiUsage extends MethodSignature {
27+
/**
28+
* Contains the name of the library containing the method declaration, e.g. `sql2o-1.6.0.jar` or `System.Runtime.dll`
29+
*/
30+
library: string;
2831
/**
2932
* Is this method already supported by CodeQL standard libraries.
3033
* If so, there is no need for the user to model it themselves.
3134
*/
3235
supported: boolean;
3336
usages: Call[];
34-
};
37+
}

0 commit comments

Comments
 (0)