Merge pull request #382 from jcreedcmu/jcreed/zip-logging

jcreedcmu · web-flow · commit fac5f98d8072 · 2020-05-26T12:38:40.000-04:00
Log more details when source archive entries aren't found
diff --git a/extensions/ql-vscode/src/archive-filesystem-provider.ts b/extensions/ql-vscode/src/archive-filesystem-provider.ts
@@ -238,7 +238,7 @@ export class ArchiveFileSystemProvider implements vscode.FileSystemProvider {
     if (archive.dirMap.has(reqPath)) {
       return new Directory(reqPath);
     }
-    throw vscode.FileSystemError.FileNotFound(uri);
+    throw vscode.FileSystemError.FileNotFound(`uri '${uri.toString()}', interpreted as '${reqPath}' in archive '${ref.sourceArchiveZipPath}'`);
   }
 
   private async _lookupAsFile(uri: vscode.Uri): Promise<File> {

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ export class ArchiveFileSystemProvider implements vscode.FileSystemProvider {`
`238`	`238`	`if (archive.dirMap.has(reqPath)) {`
`239`	`239`	`return new Directory(reqPath);`
`240`	`240`	`}`
`241`		`- throw vscode.FileSystemError.FileNotFound(uri);`
	`241`	+ throw vscode.FileSystemError.FileNotFound(`uri '${uri.toString()}', interpreted as '${reqPath}' in archive '${ref.sourceArchiveZipPath}'`);
`242`	`242`	`}`
`243`	`243`
`244`	`244`	`private async _lookupAsFile(uri: vscode.Uri): Promise<File> {`