Skip to content

Commit fd1c7f3

Browse files
Make onChange optional
1 parent 040a91a commit fd1c7f3

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

extensions/ql-vscode/src/view/common/Dropdown.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ type Props = {
2020
options: Array<{ value: string; label: string }>;
2121
disabled?: boolean;
2222
disabledPlaceholder?: string;
23-
onChange: (event: ChangeEvent<HTMLSelectElement>) => void;
23+
onChange?: (event: ChangeEvent<HTMLSelectElement>) => void;
2424
};
2525

2626
/**

extensions/ql-vscode/src/view/model-editor/InProgressDropdown.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,12 @@ import * as React from "react";
22
import { Dropdown } from "../common/Dropdown";
33

44
export const InProgressDropdown = () => {
5-
const noop = () => {
6-
// Do nothing
7-
};
8-
95
return (
106
<Dropdown
117
value="Thinking..."
128
options={[]}
139
disabled={true}
1410
disabledPlaceholder="Thinking..."
15-
onChange={noop}
1611
/>
1712
);
1813
};

0 commit comments

Comments
 (0)