Skip to content

Commit feb4bb6

Browse files
committed
Drop v2 from automodel code
1 parent 2a5b6ea commit feb4bb6

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

extensions/ql-vscode/src/data-extensions-editor/auto-model-api-v2.ts renamed to extensions/ql-vscode/src/data-extensions-editor/auto-model-api.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export interface ModelResponse {
1717
models: string;
1818
}
1919

20-
export async function autoModelV2(
20+
export async function autoModel(
2121
credentials: Credentials,
2222
request: ModelRequest,
2323
): Promise<ModelResponse> {

extensions/ql-vscode/src/data-extensions-editor/auto-model-v2.ts renamed to extensions/ql-vscode/src/data-extensions-editor/auto-model.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { AutomodelMode, ModelRequest } from "./auto-model-api-v2";
1+
import { AutomodelMode, ModelRequest } from "./auto-model-api";
22
import { Mode } from "./shared/mode";
33
import { AutoModelQueriesResult } from "./auto-model-codeml-queries";
44
import { assertNever } from "../common/helpers-pure";
@@ -66,7 +66,7 @@ export async function encodeSarif(log: Sarif.Log): Promise<string> {
6666
return compressed.toString("base64");
6767
}
6868

69-
export async function createAutoModelV2Request(
69+
export async function createAutoModelRequest(
7070
mode: Mode,
7171
result: AutoModelQueriesResult,
7272
): Promise<ModelRequest> {

extensions/ql-vscode/src/data-extensions-editor/auto-modeler.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import { ModeledMethod } from "./modeled-method";
33
import { extLogger } from "../common/logging/vscode";
44
import { load as loadYaml } from "js-yaml";
55
import { ProgressCallback, withProgress } from "../common/vscode/progress";
6-
import { createAutoModelV2Request, getCandidates } from "./auto-model-v2";
6+
import { createAutoModelRequest, getCandidates } from "./auto-model";
77
import { runAutoModelQueries } from "./auto-model-codeml-queries";
88
import { loadDataExtensionYaml } from "./yaml";
9-
import { ModelRequest, ModelResponse, autoModelV2 } from "./auto-model-api-v2";
9+
import { ModelRequest, ModelResponse, autoModel } from "./auto-model-api";
1010
import { RequestError } from "@octokit/request-error";
1111
import { showAndLogExceptionWithTelemetry } from "../common/logging";
1212
import { redactableError } from "../common/errors";
@@ -183,7 +183,7 @@ export class AutoModeler {
183183
return;
184184
}
185185

186-
const request = await createAutoModelV2Request(mode, usages);
186+
const request = await createAutoModelRequest(mode, usages);
187187

188188
void extLogger.log("Calling auto-model API");
189189

@@ -229,7 +229,7 @@ export class AutoModeler {
229229
request: ModelRequest,
230230
): Promise<ModelResponse | null> {
231231
try {
232-
return await autoModelV2(this.app.credentials, request);
232+
return await autoModel(this.app.credentials, request);
233233
} catch (e) {
234234
if (e instanceof RequestError && e.status === 429) {
235235
void showAndLogExceptionWithTelemetry(

extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ export class DataExtensionsEditorView extends AbstractWebview<
168168

169169
break;
170170
case "generateExternalApiFromLlm":
171-
await this.generateModeledMethodsFromLlmV2(
171+
await this.generateModeledMethodsFromLlm(
172172
msg.packageName,
173173
msg.externalApiUsages,
174174
msg.modeledMethods,
@@ -374,7 +374,7 @@ export class DataExtensionsEditorView extends AbstractWebview<
374374
);
375375
}
376376

377-
private async generateModeledMethodsFromLlmV2(
377+
private async generateModeledMethodsFromLlm(
378378
packageName: string,
379379
externalApiUsages: ExternalApiUsage[],
380380
modeledMethods: Record<string, ModeledMethod>,

extensions/ql-vscode/test/unit-tests/data-extensions-editor/auto-model-v2.test.ts renamed to extensions/ql-vscode/test/unit-tests/data-extensions-editor/auto-model.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import {
2-
createAutoModelV2Request,
2+
createAutoModelRequest,
33
encodeSarif,
44
getCandidates,
5-
} from "../../../src/data-extensions-editor/auto-model-v2";
5+
} from "../../../src/data-extensions-editor/auto-model";
66
import { Mode } from "../../../src/data-extensions-editor/shared/mode";
7-
import { AutomodelMode } from "../../../src/data-extensions-editor/auto-model-api-v2";
7+
import { AutomodelMode } from "../../../src/data-extensions-editor/auto-model-api";
88
import { AutoModelQueriesResult } from "../../../src/data-extensions-editor/auto-model-codeml-queries";
99
import * as sarif from "sarif";
1010
import { gzipDecode } from "../../../src/common/zlib";
1111
import { ExternalApiUsage } from "../../../src/data-extensions-editor/external-api-usage";
1212
import { ModeledMethod } from "../../../src/data-extensions-editor/modeled-method";
1313

14-
describe("createAutoModelV2Request", () => {
14+
describe("createAutoModelRequest", () => {
1515
const createSarifLog = (queryId: string): sarif.Log => {
1616
return {
1717
version: "2.1.0",
@@ -68,14 +68,14 @@ describe("createAutoModelV2Request", () => {
6868
};
6969

7070
it("creates a matching request", async () => {
71-
expect(await createAutoModelV2Request(Mode.Application, result)).toEqual({
71+
expect(await createAutoModelRequest(Mode.Application, result)).toEqual({
7272
mode: AutomodelMode.Application,
7373
candidates: await encodeSarif(result.candidates),
7474
});
7575
});
7676

7777
it("can decode the SARIF", async () => {
78-
const request = await createAutoModelV2Request(Mode.Application, result);
78+
const request = await createAutoModelRequest(Mode.Application, result);
7979
const decoded = Buffer.from(request.candidates, "base64");
8080
const decompressed = await gzipDecode(decoded);
8181
const json = decompressed.toString("utf-8");

0 commit comments

Comments
 (0)