Add unit tests to check codeQLDatabasesExperimental.configError value (#1876)

Author: shati-patel

extensions/ql-vscode/src/databases/config/db-config-store.ts

@@ -151,11 +151,6 @@ export class DbConfigStore extends DisposableObject {
           message: `Failed to read config file: ${this.configPath}`,
         },
       ];
-      await this.app.executeCommand(
-        "setContext",
-        "codeQLDatabasesExperimental.configError",
-        true,
-      );
     }
 
     if (newConfig) {
@@ -171,6 +166,11 @@ export class DbConfigStore extends DisposableObject {
       );
     } else {
       this.config = undefined;
+      await this.app.executeCommand(
+        "setContext",
+        "codeQLDatabasesExperimental.configError",
+        true,
+      );
     }
   }
 
@@ -185,11 +185,6 @@ export class DbConfigStore extends DisposableObject {
           message: `Failed to read config file: ${this.configPath}`,
         },
       ];
-      void this.app.executeCommand(
-        "setContext",
-        "codeQLDatabasesExperimental.configError",
-        true,
-      );
     }
 
     if (newConfig) {
@@ -205,6 +200,11 @@ export class DbConfigStore extends DisposableObject {
       );
     } else {
       this.config = undefined;
+      void this.app.executeCommand(
+        "setContext",
+        "codeQLDatabasesExperimental.configError",
+        true,
+      );
     }
     this.onDidChangeConfigEventEmitter.fire();
   }

extensions/ql-vscode/test/pure-tests/databases/config/data/invalid/workspace-databases.json

@@ -0,0 +1 @@
+{}

extensions/ql-vscode/test/pure-tests/databases/config/db-config-store.test.ts

@@ -128,4 +128,39 @@ describe("db config store", () => {
 
     configStore.dispose();
   });
+
+  it("should set codeQLDatabasesExperimental.configError to true when config has error", async () => {
+    const testDataStoragePathInvalid = join(__dirname, "data", "invalid");
+
+    const app = createMockApp({
+      extensionPath,
+      workspaceStoragePath: testDataStoragePathInvalid,
+    });
+    const configStore = new DbConfigStore(app);
+    await configStore.initialize();
+
+    expect(app.executeCommand).toBeCalledWith(
+      "setContext",
+      "codeQLDatabasesExperimental.configError",
+      true,
+    );
+    configStore.dispose();
+  });
+
+  it("should set codeQLDatabasesExperimental.configError to false when config is valid", async () => {
+    const app = createMockApp({
+      extensionPath,
+      workspaceStoragePath: testDataStoragePath,
+    });
+    const configStore = new DbConfigStore(app);
+    await configStore.initialize();
+
+    expect(app.executeCommand).toBeCalledWith(
+      "setContext",
+      "codeQLDatabasesExperimental.configError",
+      false,
+    );
+
+    configStore.dispose();
+  });
 });