Merge pull request #66 from github/joshmgross/update-variables

Allow updating variables in the sidebar

Author: joshmgross

package.json

@@ -183,6 +183,15 @@
           "light": "resources/icons/light/add.svg"
         }
       },
+      {
+        "command": "github-actions.settings.variable.update",
+        "category": "GitHub Actions",
+        "title": "Update variable",
+        "icon": {
+          "dark": "resources/icons/dark/edit.svg",
+          "light": "resources/icons/light/edit.svg"
+        }
+      },
       {
         "command": "github-actions.workflow.pin",
         "category": "GitHub Actions",
@@ -320,6 +329,11 @@
           "group": "inline",
           "when": "viewItem == 'repo-variables' || viewItem == 'environment-variables'"
         },
+        {
+          "command": "github-actions.settings.variable.update",
+          "group": "inline",
+          "when": "viewItem == 'repo-variable' || viewItem == 'env-variable'"
+        },
         {
           "command": "github-actions.workflow.run.open",
           "when": "viewItem =~ /run\\s/",
@@ -367,6 +381,10 @@
           "command": "github-actions.settings.variable.add",
           "when": "false"
         },
+        {
+          "command": "github-actions.settings.variable.update",
+          "when": "false"
+        },
         {
           "command": "github-actions.workflow.pin",
           "when": "false"

src/commands/variables/updateVariable.ts

@@ -0,0 +1,50 @@
+import * as vscode from "vscode";
+import {VariableCommandArgs} from "../../treeViews/settings/variableNode";
+
+export function registerUpdateVariable(context: vscode.ExtensionContext) {
+  context.subscriptions.push(
+    vscode.commands.registerCommand("github-actions.settings.variable.update", async (args: VariableCommandArgs) => {
+      const {gitHubRepoContext, variable, environment} = args;
+
+      const name = await vscode.window.showInputBox({
+        prompt: "Enter the new variable name",
+        value: variable.name
+      });
+
+      const value = await vscode.window.showInputBox({
+        prompt: "Enter the new variable value",
+        value: variable.value
+      });
+
+      if (name == variable.name && value == variable.value) {
+        return;
+      }
+
+      const payload: {name?: string; value?: string} = {};
+      if (name != variable.name) {
+        payload.name = name;
+      }
+      if (value != variable.value) {
+        payload.value = value;
+      }
+
+      try {
+        if (environment) {
+          await gitHubRepoContext.client.request(
+            `PATCH /repositories/${gitHubRepoContext.id}/environments/${environment.name}/variables/${variable.name}`,
+            payload
+          );
+        } else {
+          await gitHubRepoContext.client.request(
+            `PATCH /repos/${gitHubRepoContext.owner}/${gitHubRepoContext.name}/actions/variables/${variable.name}`,
+            payload
+          );
+        }
+      } catch (e) {
+        await vscode.window.showErrorMessage((e as Error).message);
+      }
+
+      await vscode.commands.executeCommand("github-actions.explorer.refresh");
+    })
+  );
+}

src/extension.ts

@@ -15,6 +15,7 @@ import {registerUpdateSecret} from "./commands/secrets/updateSecret";
 import {registerTriggerWorkflowRun} from "./commands/triggerWorkflowRun";
 import {registerUnPinWorkflow} from "./commands/unpinWorkflow";
 import {registerAddVariable} from "./commands/variables/addVariable";
+import {registerUpdateVariable} from "./commands/variables/updateVariable";
 import {initConfiguration} from "./configuration/configuration";
 import {getGitHubContext} from "./git/repository";
 import {LogScheme} from "./logs/constants";
@@ -64,6 +65,7 @@ export async function activate(context: vscode.ExtensionContext) {
   registerUpdateSecret(context);
 
   registerAddVariable(context);
+  registerUpdateVariable(context);
 
   registerPinWorkflow(context);
   registerUnPinWorkflow(context);

src/treeViews/settings/environmentVariablesNode.ts

@@ -23,7 +23,7 @@ export class EnvironmentVariablesNode extends vscode.TreeItem {
         environment_name: this.environment.name,
         per_page: 100
       },
-      response => response.data.map(v => new VariableNode(this.gitHubRepoContext, v, "env"))
+      response => response.data.map(v => new VariableNode(this.gitHubRepoContext, v, this.environment))
     );
 
     if (!variables || variables.length === 0) {

src/treeViews/settings/repoVariablesNode.ts

@@ -19,7 +19,7 @@ export class RepoVariablesNode extends vscode.TreeItem {
         repo: this.gitHubRepoContext.name,
         per_page: 100
       },
-      response => response.data.map(s => new VariableNode(this.gitHubRepoContext, s, "repo"))
+      response => response.data.map(s => new VariableNode(this.gitHubRepoContext, s))
     );
   }
 }

src/treeViews/settings/variableNode.ts

@@ -1,16 +1,18 @@
 import * as vscode from "vscode";
 import {GitHubRepoContext} from "../../git/repository";
-import {EnvironmentVariable, RepoVariable} from "../../model";
+import {Environment, EnvironmentVariable, RepoVariable} from "../../model";
+
+export type VariableCommandArgs = Pick<VariableNode, "gitHubRepoContext" | "variable" | "environment">;
 
 export class VariableNode extends vscode.TreeItem {
   constructor(
     public readonly gitHubRepoContext: GitHubRepoContext,
     public readonly variable: EnvironmentVariable | RepoVariable,
-    public readonly contextPrefix: string
+    public readonly environment?: Environment
   ) {
     super(variable.name);
     this.description = variable.value;
 
-    this.contextValue = contextPrefix ? `${contextPrefix}-variable` : "variable";
+    this.contextValue = environment ? "env-variable" : "repo-variable";
   }
 }