Remove step links to logs

Author: elbrenn

package.json

@@ -118,7 +118,7 @@
         "command": "github-actions.workflow.logs",
         "category": "GitHub Actions",
         "title": "View logs",
-        "when": "viewItem =~ /job/ || viewItem =~ /step/",
+        "when": "viewItem =~ /job/",
         "icon": {
           "dark": "resources/icons/dark/logs.svg",
           "light": "resources/icons/light/logs.svg"

src/commands/openWorkflowJobLogs.ts

@@ -9,15 +9,13 @@ import {WorkflowJob} from "../store/WorkflowJob";
 export interface OpenWorkflowJobLogsCommandArgs {
   gitHubRepoContext: GitHubRepoContext;
   job: WorkflowJob;
-  step?: WorkflowStep;
 }
 
 export function registerOpenWorkflowJobLogs(context: vscode.ExtensionContext) {
   context.subscriptions.push(
     vscode.commands.registerCommand("github-actions.workflow.logs", async (args: OpenWorkflowJobLogsCommandArgs) => {
       const gitHubRepoContext = args.gitHubRepoContext;
       const job = args.job;
-      const step = args.step;
       const uri = buildLogURI(
         `%23${job.job.run_id} - ${job.job.name}`,
         gitHubRepoContext.owner,
@@ -37,22 +35,6 @@ export function registerOpenWorkflowJobLogs(context: vscode.ExtensionContext) {
 
       // Custom formatting after the editor has been opened
       updateDecorations(editor, logInfo);
-
-      // Deep linking to steps
-      if (step) {
-        let matchingSection = logInfo.sections.find(s => s.name && s.name === step.name);
-        if (!matchingSection) {
-          // If we cannot match by name, see if we can try to match by number
-          matchingSection = logInfo.sections[step.number - 1];
-        }
-
-        if (matchingSection) {
-          editor.revealRange(
-            new vscode.Range(matchingSection.start, 0, matchingSection.start, 0),
-            vscode.TextEditorRevealType.InCenter
-          );
-        }
-      }
     })
   );
 }

src/logs/model.ts

@@ -3,13 +3,7 @@ const groupMarker = "##[group]";
 
 import {Parser, IStyle} from "./parser";
 
-export enum Type {
-  Setup,
-  Step
-}
-
 export interface LogSection {
-  type: Type;
   start: number;
   end: number;
   name?: string;
@@ -30,7 +24,6 @@ export interface LogInfo {
 export function parseLog(log: string): LogInfo {
   let firstSection: LogSection | null = {
     name: "Setup",
-    type: Type.Setup,
     start: 0,
     end: 1
   };
@@ -65,7 +58,6 @@ export function parseLog(log: string): LogInfo {
 
       currentRange = {
         name,
-        type: Type.Step,
         start: lineIdx,
         end: lineIdx + 1
       };

src/logs/scheme.ts

@@ -12,7 +12,6 @@ export function parseUri(uri: vscode.Uri): {
   owner: string;
   repo: string;
   jobId: number;
-  stepName?: string;
 } {
   if (uri.scheme != LogScheme) {
     throw new Error("Uri is not of log scheme");
@@ -21,7 +20,6 @@ export function parseUri(uri: vscode.Uri): {
   return {
     owner: uri.authority,
     repo: uri.path.split("/").slice(0, 2).join(""),
-    jobId: parseInt(uri.query, 10),
-    stepName: uri.fragment
+    jobId: parseInt(uri.query, 10)
   };
 }

src/treeViews/workflows/workflowStepNode.ts

@@ -17,12 +17,6 @@ export class WorkflowStepNode extends vscode.TreeItem {
       this.contextValue += " completed";
     }
 
-    this.command = {
-      title: "Open run",
-      command: "github-actions.workflow.logs",
-      arguments: [this]
-    };
-
     this.iconPath = getIconForWorkflowStep(this.step);
   }
 }