fix EEXIST, file already exists '/tmp/graphql-language-service' failling tests (#3898)

* upd

* Apply suggestions from code review

Author: dimaMachina

.eslintrc.js

@@ -61,7 +61,7 @@ module.exports = {
         'plugin:react/jsx-runtime',
         'prettier',
       ],
-      plugins: ['promise', 'sonarjs', 'unicorn', 'sonar', '@shopify'],
+      plugins: ['promise', 'sonarjs', 'unicorn', '@shopify'],
       globals: {
         atom: false,
         document: false,
@@ -327,8 +327,9 @@ module.exports = {
         '@typescript-eslint/no-unused-expressions': 'error',
         'sonarjs/no-small-switch': 'error',
         'sonarjs/no-duplicated-branches': 'error',
-        'sonar/prefer-promise-shorthand': 'error',
-        'sonar/no-dead-store': 'error',
+        'sonarjs/prefer-promise-shorthand': 'error',
+        'sonarjs/no-dead-store': 'error',
+        'sonarjs/void-use': 'error',
         'unicorn/prefer-node-protocol': 'error',
         'import-x/no-unresolved': [
           'error',
@@ -540,7 +541,7 @@ module.exports = {
         'no-undef': 'off',
         'react/jsx-no-undef': 'off',
         'react-hooks/rules-of-hooks': 'off',
-        'sonar/no-dead-store': 'off',
+        'sonarjs/no-dead-store': 'off',
         '@typescript-eslint/no-restricted-imports': 'off',
       },
     },

package.json

@@ -119,8 +119,7 @@
     "eslint-plugin-promise": "^7.2.1",
     "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-hooks": "^6.0.0-rc.1",
-    "eslint-plugin-sonar": "^0.14.1",
-    "eslint-plugin-sonarjs": "^1.0.4",
+    "eslint-plugin-sonarjs": "^3.0.2",
     "eslint-plugin-unicorn": "^56.0.0",
     "execa": "^7.1.1",
     "identity-obj-proxy": "^3.0.0",

packages/graphiql-toolkit/src/async-helpers/index.ts

@@ -67,6 +67,7 @@ async function asyncIterableToPromise<T>(
 
   const result = await iteratorNext();
   // ensure cleanup
+  // eslint-disable-next-line sonarjs/void-use -- conflicts with @typescript-eslint/no-floating-promises
   void iteratorReturn?.();
   return result.value;
 }

packages/graphql-language-service-server/src/MessageProcessor.ts

@@ -138,10 +138,13 @@ export class MessageProcessor {
     this._tmpDirBase = path.join(this._tmpDir, 'graphql-language-service');
     // use legacy mode by default for backwards compatibility
     this._loadConfigOptions = { legacy: true, ...loadConfigOptions };
-
-    if (!existsSync(this._tmpDirBase)) {
-      void mkdirSync(this._tmpDirBase);
-    }
+    /**
+     * existsSync(this._tmpDirBase) with mkdirSync(this._tmpDirBase) provoke race condition, we use
+     * `{ recursive: true }` that way, if the directory already exists, it does not throw.
+     */
+    // if (!existsSync(this._tmpDirBase)) {
+    mkdirSync(this._tmpDirBase, { recursive: true });
+    // }
   }
   get connection(): Connection {
     return this._connection;