Revert "refactor buildResolveInfo into a lazy class (#4530)" (#4553)

Sadly, this would break existing users that resolver functions by spreading the info argument.

BREAKING CHANGE: this PR changes `info.abortSignal` to `info.getAbortSignal()` => while `info` as a whole is not lazy, changing to a method allows us to maintain laziness at least with regards to the creation of the abort signal.

Author: yaacovCR

src/execution/Executor.ts

@@ -51,7 +51,7 @@ import {
   collectFields,
   collectSubfields as _collectSubfields,
 } from './collectFields.js';
-import { ResolveInfo } from './ResolveInfo.js';
+import { buildResolveInfo } from './execute.js';
 import type { VariableValues } from './values.js';
 import { getArgumentValues } from './values.js';
 
@@ -199,13 +199,13 @@ export interface FormattedExecutionResult<
 export class Executor {
   validatedExecutionArgs: ValidatedExecutionArgs;
   finished: boolean;
-  resolverAbortControllers: Set<AbortController>;
+  resolverAbortControllers: Map<Path, AbortController>;
   collectedErrors: CollectedErrors;
 
   constructor(validatedExecutionArgs: ValidatedExecutionArgs) {
     this.validatedExecutionArgs = validatedExecutionArgs;
     this.finished = false;
-    this.resolverAbortControllers = new Set();
+    this.resolverAbortControllers = new Map();
     this.collectedErrors = new CollectedErrors();
   }
 
@@ -306,10 +306,24 @@ export class Executor {
     const { resolverAbortControllers } = this;
     const finishReason =
       reason ?? new Error('Execution has already completed.');
-    for (const abortController of resolverAbortControllers) {
+    for (const abortController of resolverAbortControllers.values()) {
       abortController.abort(finishReason);
     }
   }
+
+  getAbortSignal(path: Path): AbortSignal {
+    const resolverAbortSignal = this.resolverAbortControllers.get(path)?.signal;
+    if (resolverAbortSignal !== undefined) {
+      return resolverAbortSignal;
+    }
+    const abortController = new AbortController();
+    this.resolverAbortControllers.set(path, abortController);
+    if (this.finished) {
+      abortController.abort(new Error('Execution has already completed.'));
+    }
+    return abortController.signal;
+  }
+
   /**
    * Given a completed execution context and data, build the `{ errors, data }`
    * response defined by the "Response" section of the GraphQL specification.
@@ -469,26 +483,13 @@ export class Executor {
     const returnType = fieldDef.type;
     const resolveFn = fieldDef.resolve ?? validatedExecutionArgs.fieldResolver;
 
-    const info = new ResolveInfo(
+    const info = buildResolveInfo(
       validatedExecutionArgs,
       fieldDef,
-      fieldDetailsList,
+      toNodes(fieldDetailsList),
       parentType,
       path,
-      () => {
-        /* c8 ignore next 3 */
-        if (this.finished) {
-          throw new Error('Execution has already completed.');
-        }
-        const abortController = new AbortController();
-        this.resolverAbortControllers.add(abortController);
-        return {
-          abortSignal: abortController.signal,
-          unregister: () => {
-            this.resolverAbortControllers.delete(abortController);
-          },
-        };
-      },
+      () => this.getAbortSignal(path),
     );
 
     // Get the resolve function, regardless of if its result is normal or abrupt (error).
@@ -533,20 +534,20 @@ export class Executor {
         // to take a second callback for the error case.
         return completed.then(
           (resolved) => {
-            info.unregisterAbortSignal();
+            this.resolverAbortControllers.delete(path);
             return resolved;
           },
           (rawError: unknown) => {
-            info.unregisterAbortSignal();
+            this.resolverAbortControllers.delete(path);
             this.handleFieldError(rawError, returnType, fieldDetailsList, path);
             return null;
           },
         );
       }
-      info.unregisterAbortSignal();
+      this.resolverAbortControllers.delete(path);
       return completed;
     } catch (rawError) {
-      info.unregisterAbortSignal();
+      this.resolverAbortControllers.delete(path);
       this.handleFieldError(rawError, returnType, fieldDetailsList, path);
       return null;
     }
@@ -606,7 +607,7 @@ export class Executor {
   completeValue(
     returnType: GraphQLOutputType,
     fieldDetailsList: FieldDetailsList,
-    info: ResolveInfo,
+    info: GraphQLResolveInfo,
     path: Path,
     result: unknown,
   ): PromiseOrValue<unknown> {
@@ -690,7 +691,7 @@ export class Executor {
   async completePromisedValue(
     returnType: GraphQLOutputType,
     fieldDetailsList: FieldDetailsList,
-    info: ResolveInfo,
+    info: GraphQLResolveInfo,
     path: Path,
     result: Promise<unknown>,
     isFieldValue?: boolean,
@@ -711,12 +712,12 @@ export class Executor {
         completed = await completed;
       }
       if (isFieldValue) {
-        info.unregisterAbortSignal();
+        this.resolverAbortControllers.delete(path);
       }
       return completed;
     } catch (rawError) {
       if (isFieldValue) {
-        info.unregisterAbortSignal();
+        this.resolverAbortControllers.delete(path);
       }
       this.handleFieldError(rawError, returnType, fieldDetailsList, path);
       return null;
@@ -730,7 +731,7 @@ export class Executor {
   async completeAsyncIterableValue(
     itemType: GraphQLOutputType,
     fieldDetailsList: FieldDetailsList,
-    info: ResolveInfo,
+    info: GraphQLResolveInfo,
     path: Path,
     items: AsyncIterable<unknown>,
   ): Promise<ReadonlyArray<unknown>> {
@@ -806,7 +807,7 @@ export class Executor {
   completeListValue(
     returnType: GraphQLList<GraphQLOutputType>,
     fieldDetailsList: FieldDetailsList,
-    info: ResolveInfo,
+    info: GraphQLResolveInfo,
     path: Path,
     result: unknown,
   ): PromiseOrValue<ReadonlyArray<unknown>> {
@@ -840,7 +841,7 @@ export class Executor {
   completeIterableValue(
     itemType: GraphQLOutputType,
     fieldDetailsList: FieldDetailsList,
-    info: ResolveInfo,
+    info: GraphQLResolveInfo,
     path: Path,
     items: Iterable<unknown>,
   ): PromiseOrValue<ReadonlyArray<unknown>> {
@@ -905,7 +906,7 @@ export class Executor {
     completedResults: Array<unknown>,
     itemType: GraphQLOutputType,
     fieldDetailsList: FieldDetailsList,
-    info: ResolveInfo,
+    info: GraphQLResolveInfo,
     itemPath: Path,
   ): boolean {
     try {
@@ -946,7 +947,7 @@ export class Executor {
     item: Promise<unknown>,
     itemType: GraphQLOutputType,
     fieldDetailsList: FieldDetailsList,
-    info: ResolveInfo,
+    info: GraphQLResolveInfo,
     itemPath: Path,
   ): Promise<unknown> {
     try {