Skip to content

Commit 59f8880

Browse files
authored
internal: remove version/preversion scripts (#4603)
these are now covered by "npm run release:prepare" -- removes need to add `ignore-scripts=false` when running `npm version`
1 parent ad9e264 commit 59f8880

File tree

3 files changed

+23
-42
lines changed

3 files changed

+23
-42
lines changed

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@
2929
"node": "^20.0.0 || ^22.0.0 || ^24.0.0 || >=25.0.0"
3030
},
3131
"scripts": {
32-
"preversion": "bash -c '. ./resources/checkgit.sh && npm ci --ignore-scripts'",
33-
"version": "node --import ./resources/register-ts-node.js resources/gen-version.ts && npm test && git add src/version.ts",
3432
"fuzzonly": "mocha --full-trace src/**/__tests__/**/*-fuzz.ts",
3533
"changelog": "node --import ./resources/register-ts-node.js resources/gen-changelog.ts",
3634
"release:prepare": "node --import ./resources/register-ts-node.js resources/release-prepare.ts",

resources/checkgit.sh

Lines changed: 0 additions & 39 deletions
This file was deleted.

resources/release-prepare.ts

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,24 @@ try {
99
process.exit(1);
1010
}
1111

12-
console.log('Running npm version without creating a tag...');
12+
console.log('Installing dependencies...');
13+
npm().ci('--ignore-scripts');
14+
15+
console.log('Bumping package version without creating a tag...');
1316
npm().version(...args.npmVersionArgs, '--no-git-tag-version');
1417

18+
console.log('Updating src/version.ts...');
19+
npm().exec(
20+
'--',
21+
'node',
22+
'--import',
23+
'./resources/register-ts-node.js',
24+
'resources/gen-version.ts',
25+
);
26+
27+
console.log('Running test suite...');
28+
npm().run('test');
29+
1530
const { version } = readPackageJSON();
1631
console.log(`Generating changelog for v${version}...`);
1732
const changelogArgs = ['--silent', 'changelog'];
@@ -97,6 +112,13 @@ function validateBranchState(releaseBranch: string): void {
97112
'Working directory must be clean before running release:prepare.',
98113
);
99114
}
115+
const branchStatus = git().status('--porcelain', '--branch');
116+
const branchSummary = branchStatus.split('\n')[0] ?? '';
117+
if (/\[[^\]]+\]/.test(branchSummary)) {
118+
throw new Error(
119+
`Current branch "${checkedBranch}" is not up to date with its upstream.`,
120+
);
121+
}
100122

101123
let releaseBranchHead: string;
102124
try {

0 commit comments

Comments
 (0)