Test coverage

Author: benjie

src/language/__tests__/parser-test.ts

@@ -8,9 +8,11 @@ import { kitchenSinkQuery } from '../../__testUtils__/kitchenSinkQuery';
 import { inspect } from '../../jsutils/inspect';
 
 import { Kind } from '../kinds';
+import { Lexer } from '../lexer';
 import {
   parse,
   parseConstValue,
+  Parser,
   parseSchemaCoordinate,
   parseType,
   parseValue,
@@ -115,6 +117,18 @@ describe('Parser', () => {
     );
   });
 
+  it('forbids maxTokens and lexer together', () => {
+    expect(
+      () =>
+        new Parser('{a}', {
+          maxTokens: 10,
+          lexer: new Lexer(new Source('{a}')),
+        }),
+    ).to.throw(
+      'Setting maxTokens has no effect when a custom lexer is supplied',
+    );
+  });
+
   it('parses variable inline values', () => {
     expect(() =>
       parse('{ field(complex: { a: { b: [ $var ] } }) }'),

src/language/__tests__/schemaCoordinateLexer-test.ts

@@ -3,6 +3,7 @@ import { describe, it } from 'mocha';
 
 import { expectToThrowJSON } from '../../__testUtils__/expectJSON';
 
+import type { Token } from '../ast';
 import { SchemaCoordinateLexer } from '../schemaCoordinateLexer';
 import { Source } from '../source';
 import { TokenKind } from '../tokenKind';
@@ -49,4 +50,13 @@ describe('SchemaCoordinateLexer', () => {
       locations: [{ line: 1, column: 4 }],
     });
   });
+
+  it('counts tokens', () => {
+    const lexer = new SchemaCoordinateLexer(new Source('Name.field'));
+    let token: Token;
+    do {
+      token = lexer.advance();
+    } while (token.kind !== TokenKind.EOF);
+    expect(lexer.tokenCount).to.eq(3);
+  });
 });

src/language/parser.ts

@@ -247,7 +247,7 @@ export class Parser {
     if (lexer) {
       if (options.maxTokens != null) {
         throw new Error(
-          'Setting maxTokens has no effect when a custom lexer is passed',
+          'Setting maxTokens has no effect when a custom lexer is supplied',
         );
       }
       this._lexer = lexer;