Skip to content

Commit faf327b

Browse files
committed
chore: remove old comments no longer apply
1 parent a13d17d commit faf327b

File tree

2 files changed

+1
-15
lines changed

2 files changed

+1
-15
lines changed

src/__testUtils__/fakeDiagnosticsChannel.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,7 @@ export class FakeChannel implements MinimalChannel {
5555

5656
/**
5757
* Structurally-faithful `MinimalTracingChannel` implementation mirroring
58-
* Node's `TracingChannel.traceSync` / `tracePromise` lifecycle (start,
59-
* runStores, error, asyncStart, asyncEnd, end).
58+
* Node's `TracingChannel.traceSync` / `tracePromise` lifecycle
6059
*/
6160
export class FakeTracingChannel implements MinimalTracingChannel {
6261
start: FakeChannel = new FakeChannel();

src/diagnostics.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -188,19 +188,6 @@ export function maybeTracePromise<T>(
188188
* Publish a mixed sync-or-promise operation through the named graphql tracing
189189
* channel.
190190
*
191-
* Mirrors Node's own `TracingChannel.tracePromise` for the async branch while
192-
* handling sync returns without the cost of a promise wrap. The entire
193-
* lifecycle runs inside `start.runStores`, which is what lets subscribers
194-
* that call `channel.start.bindStore(als, ...)` read that store in every
195-
* sub-channel handler: promise continuations attached inside a `runStores`
196-
* block inherit the AsyncLocalStorage context via async_hooks, so
197-
* `asyncStart` and `asyncEnd` fire with the same store active as `start`
198-
* and `end`.
199-
*
200-
* Subscribers can inspect `isPromise(ctx.result)` inside their `end` handler
201-
* to know whether `asyncEnd` will follow or the operation is complete. This
202-
* matches Node's convention.
203-
*
204191
* @internal
205192
*/
206193
export function maybeTraceMixed<T>(

0 commit comments

Comments
 (0)