-
-
Notifications
You must be signed in to change notification settings - Fork 7
๐ ๏ธ Refactor: maximize use of Quasar componentsย #82
Copy link
Copy link
Open
Labels
Domain: Dev ExperienceThis issue pertains to a developer's emotions and attitudes when building Grey Software.This issue pertains to a developer's emotions and attitudes when building Grey Software.Role: Software EngineerUses technology to design, develop, test, and maintain creative software solutions.Uses technology to design, develop, test, and maintain creative software solutions.
Metadata
Metadata
Assignees
Labels
Domain: Dev ExperienceThis issue pertains to a developer's emotions and attitudes when building Grey Software.This issue pertains to a developer's emotions and attitudes when building Grey Software.Role: Software EngineerUses technology to design, develop, test, and maintain creative software solutions.Uses technology to design, develop, test, and maintain creative software solutions.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Motivation ๐
I'm currently in the process of re-factoring the practice card, and there are a few glaring issues with the existing codebase, especially with the Vue SFCs. We should begin with the home page. Observe that the root element is the
q-pagecomponent. This is wrong and leads to unexpected layout behavior. From the Quasar Docs:The
QLayoutelement provides built-in components that make generating user layouts far less error prone and more well-documented. There is no need to write usedivelements with themobile-containerorconfig-headerCSS classes, when Quasar ships with dedicated components for containers and headers.Many more similar issues exist throughout the codebase, which all share a pattern of wrapping everything in a
divand writing a custom CSS class. This is really hard to read, debug, or maintain.Describe your refactoring solution ๐ ๏ธ
The main goal is to re-factor the code using Quasar elements without changing the UI at all.
Additional details โน๏ธ
I'm unsure of how to make my PRs. Do I just submit one massive PR that re-factors a ton of source files? Suggestions welcome.