Correctly use the string 'off' for autocapitalize and autocorrect

marijnh · marijnh · commit 97f6acc38047 · 2019-04-11T08:19:00.000+02:00
Rather than 'false', which is ignored Issue codemirror#3403
diff --git a/src/input/input.js b/src/input/input.js
@@ -114,8 +114,8 @@ export function copyableRanges(cm) {
 }
 
 export function disableBrowserMagic(field, spellcheck, autocorrect, autocapitalize) {
-  field.setAttribute("autocorrect", !!autocorrect)
-  field.setAttribute("autocapitalize", !!autocapitalize)
+  field.setAttribute("autocorrect", autocorrect ? "" : "off")
+  field.setAttribute("autocapitalize", autocapitalize ? "" : "off")
   field.setAttribute("spellcheck", !!spellcheck)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -114,8 +114,8 @@ export function copyableRanges(cm) {`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`export function disableBrowserMagic(field, spellcheck, autocorrect, autocapitalize) {`
`117`		`- field.setAttribute("autocorrect", !!autocorrect)`
`118`		`- field.setAttribute("autocapitalize", !!autocapitalize)`
	`117`	`+ field.setAttribute("autocorrect", autocorrect ? "" : "off")`
	`118`	`+ field.setAttribute("autocapitalize", autocapitalize ? "" : "off")`
`119`	`119`	`field.setAttribute("spellcheck", !!spellcheck)`
`120`	`120`	`}`
`121`	`121`