Return keypress when composing

muan · marijnh · commit 9cb7b7d5e556 · 2018-04-11T10:00:16.000+02:00
Keypress should not happen during composing (as spec) but it does on Windows for Korean IMEs
diff --git a/src/input/ContentEditableInput.js b/src/input/ContentEditableInput.js
@@ -355,7 +355,7 @@ export default class ContentEditableInput {
   }
 
   onKeyPress(e) {
-    if (e.charCode == 0) return
+    if (e.charCode == 0 || this.composing) return
     e.preventDefault()
     if (!this.cm.isReadOnly())
       operation(this.cm, applyTextInput)(this.cm, String.fromCharCode(e.charCode == null ? e.keyCode : e.charCode), 0)

Original file line number	Diff line number	Diff line change
`@@ -355,7 +355,7 @@ export default class ContentEditableInput {`
`355`	`355`	`}`
`356`	`356`
`357`	`357`	`onKeyPress(e) {`
`358`		`- if (e.charCode == 0) return`
	`358`	`+ if (e.charCode == 0 \|\| this.composing) return`
`359`	`359`	`e.preventDefault()`
`360`	`360`	`if (!this.cm.isReadOnly())`
`361`	`361`	`operation(this.cm, applyTextInput)(this.cm, String.fromCharCode(e.charCode == null ? e.keyCode : e.charCode), 0)`