Skip to content

Commit 41451cd

Browse files
committed
fix helm2 compatibility
1 parent 7de4957 commit 41451cd

3 files changed

Lines changed: 8 additions & 13 deletions

File tree

charts/codimd/README.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,13 @@ $ helm install my-release codimd/codimd
1919

2020
## Parameters
2121

22-
### Global parameters
22+
### Common Helm parameters
2323

2424
If you use AWS EKS, please setup global.storageClass as `gp2`
2525

26-
| Parameter | Description | Default |
27-
| ------------------- |:---------------------------------------- | ------- |
28-
| global.storageClass | default storageClass for PersistenVolume | `nil` |
29-
30-
### Common Helm parameters
31-
3226
| Parameter | Description | Default |
3327
| ---------------- |:--------------------------------------------------------------------------------------------------- | ------- |
28+
| storageClass | default storageClass for PersistenVolume | `nil` |
3429
| nameOverride | String to partially override codimd.fullname template with a string (will prepend the release name) | `nil` |
3530
| fullnameOverride | String to fully override codimd.fullname template with a string | `nil` |
3631

charts/codimd/templates/db-secret.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ stringData:
77
connection: "postgres://{{ .Values.postgresql.postgresqlUsername }}:{{ .Values.postgresql.postgresqlPassword }}@{{ template "codimd.postgresql-svc" . }}/{{ .Values.postgresql.postgresqlDatabase }}"
88
{{ else if .Values.mariadb.enabled }}
99
connection: "mysql://{{ .Values.mariadb.db.user }}:{{ .Values.mariadb.db.password }}@{{ template "codimd.mariadb-svc" . }}/{{ .Values.mariadb.db.name }}"
10-
{{ else }}
10+
{{ else if .Values.codimd.database }}
1111
connection: "{{ .Values.codimd.database.type }}://{{ .Values.codimd.database.username }}:{{ .Values.codimd.database.password }}@{{ .Values.codimd.database.host }}:{{ .Values.codimd.database.port }}/{{ .Values.codimd.database.databaseName }}"
12+
{{ else }}
13+
connection: "postgres://localhost/codimd"
1214
{{ end }}

charts/codimd/values.yaml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22
# This is a YAML-formatted file.
33
# Declare variables to be passed into your templates.
44

5-
global:
6-
# storageClass:
7-
5+
# storageClass:
86
# nameOverride:
97
# fullnameOverride:
108

@@ -24,7 +22,7 @@ image:
2422
## If you want to use external database, just set postgresql.enabled to false
2523
##
2624
postgresql:
27-
enabled: true
25+
install: true
2826
volumePermissions:
2927
enabled: true
3028
postgresqlUsername: codimd
@@ -38,7 +36,7 @@ postgresql:
3836
## If you prefer MariaDB, we also supported.
3937
##
4038
mariadb:
41-
enabled: false
39+
install: false
4240
volumePermissions:
4341
enabled: true
4442
db:

0 commit comments

Comments
 (0)