Skip to content

Commit 0f4f270

Browse files
committed
Fix yaml metadata title should pass to generateWebTitle
1 parent 246c9da commit 0f4f270

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

lib/response.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ function responseHackMD(res, note) {
108108
//na
109109
}
110110
var title = models.Note.decodeTitle(note.title);
111-
title = models.Note.generateWebTitle(title);
111+
title = models.Note.generateWebTitle(meta.title || title);
112112
var template = config.hackmdpath;
113113
var options = {
114114
cache: !config.debug,
@@ -117,7 +117,7 @@ function responseHackMD(res, note) {
117117
var compiled = ejs.compile(fs.readFileSync(template, 'utf8'), options);
118118
var html = compiled({
119119
url: config.serverurl,
120-
title: meta.title || title,
120+
title: title,
121121
useCDN: config.usecdn,
122122
facebook: config.facebook,
123123
twitter: config.twitter,
@@ -225,10 +225,10 @@ function showPublishNote(req, res, next) {
225225
var updatetime = note.lastchangeAt;
226226
var text = S(body).escapeHTML().s;
227227
var title = models.Note.decodeTitle(note.title);
228-
title = models.Note.generateWebTitle(title);
228+
title = models.Note.generateWebTitle(meta.title || title);
229229
var origin = config.serverurl;
230230
var data = {
231-
title: meta.title || title,
231+
title: title,
232232
description: meta.description,
233233
viewcount: note.viewcount,
234234
createtime: createtime,
@@ -537,6 +537,7 @@ function showPublishSlide(req, res, next) {
537537
return response.errorNotFound(res);
538538
}
539539
var body = LZString.decompressFromBase64(note.content);
540+
var meta = null;
540541
try {
541542
var obj = metaMarked(body);
542543
body = obj.markdown;
@@ -546,12 +547,12 @@ function showPublishSlide(req, res, next) {
546547
}
547548
var text = S(body).escapeHTML().s;
548549
var title = models.Note.decodeTitle(note.title);
549-
title = models.Note.generateWebTitle(title);
550+
title = models.Note.generateWebTitle(meta.title || title);
550551
var slides = md.slidify(text, slideOptions);
551552
var origin = config.serverurl;
552553
var data = {
553554
url: origin,
554-
title: meta.title || title,
555+
title: title,
555556
description: meta.description,
556557
slides: slides,
557558
GA: meta.GA,

0 commit comments

Comments
 (0)