Skip to content

Commit 66c6825

Browse files
committed
refactor(app.js): Extract index, 403, 404, 500 pages
1 parent 9f1f16c commit 66c6825

2 files changed

Lines changed: 24 additions & 14 deletions

File tree

app.js

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -199,20 +199,6 @@ app.set('views', path.join(__dirname, '/public/views'))
199199
app.engine('ejs', ejs.renderFile)
200200
// set view engine
201201
app.set('view engine', 'ejs')
202-
// get index
203-
app.get('/', response.showIndex)
204-
// get 403 forbidden
205-
app.get('/403', function (req, res) {
206-
response.errorForbidden(res)
207-
})
208-
// get 404 not found
209-
app.get('/404', function (req, res) {
210-
response.errorNotFound(res)
211-
})
212-
// get 500 internal error
213-
app.get('/500', function (req, res) {
214-
response.errorInternalError(res)
215-
})
216202
// get status
217203
app.get('/status', function (req, res, next) {
218204
realtime.getStatus(function (data) {
@@ -430,6 +416,7 @@ if (config.email) {
430416
})
431417
})
432418
}
419+
app.use(require('./lib/web/baseRouter'))
433420

434421
app.post('/login', urlencodedParser, function (req, res, next) {
435422
if (!req.body.email || !req.body.password) return response.errorBadRequest(res)

lib/web/baseRouter.js

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
'use strict'
2+
3+
const Router = require('express').Router
4+
5+
const response = require('../response')
6+
7+
const baseRouter = module.exports = Router()
8+
9+
// get index
10+
baseRouter.get('/', response.showIndex)
11+
// get 403 forbidden
12+
baseRouter.get('/403', function (req, res) {
13+
response.errorForbidden(res)
14+
})
15+
// get 404 not found
16+
baseRouter.get('/404', function (req, res) {
17+
response.errorNotFound(res)
18+
})
19+
// get 500 internal error
20+
baseRouter.get('/500', function (req, res) {
21+
response.errorInternalError(res)
22+
})
23+

0 commit comments

Comments
 (0)