Skip to content

Commit ad69c50

Browse files
committed
Removing google drive integration
It's sad but it's not working. For multiple releases this should be already broken which shows how often it's used. As there is also a security issue related to that, it's better to remove the feature completely. Whoever wants to rewrite it, feel free to go. This commit removes the Google Drive integration from HackMD's Frontend editor and this way removes the need to provide any API key and Client ID in the frontend. Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
1 parent b8e7c4b commit ad69c50

11 files changed

Lines changed: 3 additions & 516 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ There are some config settings you need to change in the files below.
272272
| ------- | --------- | ----------- |
273273
| facebook, twitter, github, gitlab, mattermost, dropbox, google, ldap, saml | environment variables or `config.json` | for signin |
274274
| imgur, s3, minio | environment variables or `config.json` | for image upload |
275-
| google drive(`google/apiKey`, `google/clientID`), dropbox(`dropbox/appKey`) | `config.json` | for export and import |
275+
| dropbox(`dropbox/appKey`) | `config.json` | for export and import |
276276

277277
## Third-party integration OAuth callback URLs
278278

app.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ var data = {
3333
urlpath: config.urlPath,
3434
debug: config.debug,
3535
version: config.version,
36-
GOOGLE_API_KEY: config.google.clientSecret,
37-
GOOGLE_CLIENT_ID: config.google.clientID,
3836
DROPBOX_APP_KEY: config.dropbox.appKey,
3937
allowedUploadMimeTypes: config.allowedUploadMimeTypes
4038
}

app.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,6 @@
136136
"description": "Google API client secret",
137137
"required": false
138138
},
139-
"HMD_GOOGLE_API_KEY": {
140-
"description": "Google API key (for import/export)",
141-
"required": false
142-
},
143139
"HMD_IMGUR_CLIENTID": {
144140
"description": "Imgur API client id",
145141
"required": false

public/js/google-drive-picker.js

Lines changed: 0 additions & 118 deletions
This file was deleted.

0 commit comments

Comments
 (0)