Skip to content

Commit d88502e

Browse files
committed
refactor(app.js): Move passport serialize and deserialize to auth module
1 parent 7ef17fd commit d88502e

2 files changed

Lines changed: 22 additions & 19 deletions

File tree

app.js

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -154,25 +154,6 @@ app.use(flash())
154154
app.use(passport.initialize())
155155
app.use(passport.session())
156156

157-
// serialize and deserialize
158-
passport.serializeUser(function (user, done) {
159-
logger.info('serializeUser: ' + user.id)
160-
return done(null, user.id)
161-
})
162-
passport.deserializeUser(function (id, done) {
163-
models.User.findOne({
164-
where: {
165-
id: id
166-
}
167-
}).then(function (user) {
168-
logger.info('deserializeUser: ' + user.id)
169-
return done(null, user)
170-
}).catch(function (err) {
171-
logger.error(err)
172-
return done(err, null)
173-
})
174-
})
175-
176157
// check uri is valid before going further
177158
app.use(require('./lib/web/middleware/checkURiValid'))
178159

lib/web/auth/index.js

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,34 @@
11
'use strict'
22

33
const Router = require('express').Router
4+
const passport = require('passport')
45

56
const config = require('../../config')
67
const logger = require('../../logger')
8+
const models = require('../../models')
79

810
const authRouter = module.exports = Router()
911

12+
// serialize and deserialize
13+
passport.serializeUser(function (user, done) {
14+
logger.info('serializeUser: ' + user.id)
15+
return done(null, user.id)
16+
})
17+
18+
passport.deserializeUser(function (id, done) {
19+
models.User.findOne({
20+
where: {
21+
id: id
22+
}
23+
}).then(function (user) {
24+
logger.info('deserializeUser: ' + user.id)
25+
return done(null, user)
26+
}).catch(function (err) {
27+
logger.error(err)
28+
return done(err, null)
29+
})
30+
})
31+
1032
if (config.facebook) authRouter.use('/', require('./facebook'))
1133
if (config.twitter) authRouter.use('/', require('./twitter'))
1234
if (config.github) authRouter.use('/', require('./github'))

0 commit comments

Comments
 (0)