Skip to content

Commit ffa14cf

Browse files
committed
Fix sortOnlineUserList might not check property existence before comparsion
1 parent fc788e8 commit ffa14cf

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

public/js/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2946,14 +2946,14 @@ function sortOnlineUserList(list) {
29462946
else if (usera.idle && !userb.idle)
29472947
return 1;
29482948
else {
2949-
if (usera.name && usera.name.toLowerCase() < userb.name.toLowerCase()) {
2949+
if (usera.name && userb.name && usera.name.toLowerCase() < userb.name.toLowerCase()) {
29502950
return -1;
2951-
} else if (usera.name && usera.name.toLowerCase() > userb.name.toLowerCase()) {
2951+
} else if (usera.name && userb.name && usera.name.toLowerCase() > userb.name.toLowerCase()) {
29522952
return 1;
29532953
} else {
2954-
if (usera.color && usera.color.toLowerCase() < userb.color.toLowerCase())
2954+
if (usera.color && userb.color && usera.color.toLowerCase() < userb.color.toLowerCase())
29552955
return -1;
2956-
else if (usera.color && usera.color.toLowerCase() > userb.color.toLowerCase())
2956+
else if (usera.color && userb.color && usera.color.toLowerCase() > userb.color.toLowerCase())
29572957
return 1;
29582958
else
29592959
return 0;

0 commit comments

Comments
 (0)