feat: Raise better error message when incorrect dataset is supplied #113 (#115)

* feat: Raise better error message on dataset [#113]

* chore: refactor tests to use pytests.raises matcher

Co-authored-by: Tim Swast <swast@google.com>

Author: hussainsultan

ibis_bigquery/client.py

@@ -319,7 +319,13 @@ def parse_project_and_dataset(project: str, dataset: str = "") -> Tuple[str, str
     None
 
     """
-    if "." in dataset:
+    if dataset.count(".") > 1:
+        raise ValueError(
+            "{} is not a BigQuery dataset. More info https://cloud.google.com/bigquery/docs/datasets-intro".format(
+                dataset
+            )
+        )
+    elif dataset.count(".") == 1:
         data_project, dataset = dataset.split(".")
         billing_project = project
     else:

tests/unit/test_client.py

@@ -19,3 +19,11 @@
 def test_parse_project_and_dataset(project, dataset, expected):
     got = ibis_bigquery.client.parse_project_and_dataset(project, dataset)
     assert got == expected
+
+
+def test_parse_project_and_dataset_raises_error():
+    expected_message = "data-project.my_dataset.table is not a BigQuery dataset"
+    with pytest.raises(ValueError, match=expected_message):
+        ibis_bigquery.client.parse_project_and_dataset(
+            "my-project", "data-project.my_dataset.table"
+        )