ci: fixes to address upcoming ibis incompatibilities (#106)

* test: remove noop constructor

* fix: ensure non-nested installation

* ci: fixup deps

* ci: remove explicit head sha as pull_request_target already runs without the merge commit

Author: cpcloud

.github/workflows/main.yml

@@ -62,7 +62,9 @@ jobs:
     steps:
 
     - name: checkout
-      uses: actions/checkout@v1
+      uses: actions/checkout@v2
+      with:
+        path: ibis_bigquery
 
     - name: checkout ibis
       uses: actions/checkout@v2
@@ -78,7 +80,7 @@ jobs:
     - name: install dependencies (ibis ${{ matrix.ibis_version }})
       env:
         IBIS_VERSION: ${{ matrix.ibis_version }}
-      run: ./ci/install_deps.sh
+      run: ./ibis_bigquery/ci/install_deps.sh
 
     - name: run tests
-      run: python -m pytest tests/unit
+      run: python -m pytest ./ibis_bigquery/tests/unit

.github/workflows/system-tests-pr.yml

@@ -27,7 +27,7 @@ jobs:
     - name: checkout
       uses: actions/checkout@v2
       with:
-        ref: ${{ github.event.pull_request.head.sha }}
+        path: ibis_bigquery
 
     - name: set up python ${{ matrix.python-version }}
       uses: actions/setup-python@v2
@@ -43,15 +43,20 @@ jobs:
     - name: install dependencies (ibis ${{ matrix.ibis_version }})
       env:
         IBIS_VERSION: ${{ matrix.ibis_version }}
-      run: ./ci/install_deps.sh
+      run: ./ibis_bigquery/ci/install_deps.sh
 
     - name: set up bigquery credentials
+      working-directory: ibis_bigquery
       run: ./ci/decrypt_secret.sh
       env:
         GCLOUD_KEY_PASSPHRASE: ${{ secrets.GCLOUD_KEY_PASSPHRASE }}
 
     - name: run tests
-      run: GOOGLE_BIGQUERY_PROJECT_ID="ibis-gbq" GOOGLE_APPLICATION_CREDENTIALS="$HOME/secrets/gcloud-service-key.json" python -m pytest tests/system --save-dataset
+      run: python -m pytest ./ibis_bigquery/tests/system --save-dataset
+      env:
+        GOOGLE_BIGQUERY_PROJECT_ID: ibis-gbq
+        GOOGLE_APPLICATION_CREDENTIALS: ${{ env.HOME }}/secrets/gcloud-service-key.json
+
 
     # Remove the label so that it can be added again to re-trigger a build
     - name: reset label

.github/workflows/system-tests.yml

@@ -24,6 +24,8 @@ jobs:
     steps:
     - name: checkout
       uses: actions/checkout@v2
+      with:
+        path: ibis_bigquery
 
     - name: set up python ${{ matrix.python-version }}
       uses: actions/setup-python@v2
@@ -39,12 +41,16 @@ jobs:
     - name: install dependencies (ibis ${{ matrix.ibis_version }})
       env:
         IBIS_VERSION: ${{ matrix.ibis_version }}
-      run: ./ci/install_deps.sh
+      run: ./ibis_bigquery/ci/install_deps.sh
 
     - name: set up bigquery credentials
+      working-directory: ibis_bigquery
       run: ./ci/decrypt_secret.sh
       env:
         GCLOUD_KEY_PASSPHRASE: ${{ secrets.GCLOUD_KEY_PASSPHRASE }}
 
     - name: run tests
-      run: GOOGLE_BIGQUERY_PROJECT_ID="ibis-gbq" GOOGLE_APPLICATION_CREDENTIALS="$HOME/secrets/gcloud-service-key.json" python -m pytest tests/system --save-dataset
+      run: python -m pytest ./ibis_bigquery/tests/system --save-dataset
+      env:
+        GOOGLE_BIGQUERY_PROJECT_ID: ibis-gbq
+        GOOGLE_APPLICATION_CREDENTIALS: ${{ env.HOME }}/secrets/gcloud-service-key.json

ci/install_deps.sh

@@ -13,10 +13,10 @@ import sys
 site.ENABLE_USER_SITE = '--user' in sys.argv[1:]
 $(cat ./ibis/setup.py)" > ./ibis/setup.py
 
-    python -m pip install --user -e ./ibis
+    python -m pip install --user ./ibis
 else
     python -m pip install --user ibis-framework=="$IBIS_VERSION"
 fi
 
-python -m pip install --user -e .
+python -m pip install --user ./ibis_bigquery
 python -m pip install --user pytest

tests/unit/test_compiler.py

@@ -318,8 +318,7 @@ def test_large_compile():
     num_joins = 7
 
     class MockBackend(ibis_bigquery.Backend):
-        def __init__(self):
-            pass
+        pass
 
     names = [f"col_{i}" for i in range(num_columns)]
     schema = ibis.Schema(names, ["string"] * num_columns)