Skip to content

Commit 7e5a8b9

Browse files
committed
Position messages correctly on coverage run
1 parent 9c9192d commit 7e5a8b9

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
11
Class vscode.dc.testingmanager.CoverageManager Extends (BaseManager, TestCoverage.Manager)
22
{
33

4+
ClassMethod RunTest(ByRef testspec As %String, qspec As %String, ByRef userparam) As %Status
5+
{
6+
Set userparam("CoverageDetail")=2
7+
Return ##super(testspec, qspec, .userparam)
8+
}
9+
10+
411
}

src/commonRunTestsHandler.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { relativeTestRoot } from './localTests';
55
import logger from './logger';
66
import { makeRESTRequest } from './makeRESTRequest';
77
import { OurFileCoverage } from './ourFileCoverage';
8-
import { SQL_FN_RUNTESTPROXY, UTIL_CLASSNAME } from './utils';
98

109
export async function commonRunTestsHandler(controller: vscode.TestController, resolveItemChildren: (item: vscode.TestItem) => Promise<void>, request: vscode.TestRunRequest, cancellation: vscode.CancellationToken) {
1110
logger.debug(`commonRunTestsHandler invoked by controller id=${controller.id}`);
@@ -254,7 +253,7 @@ export async function commonRunTestsHandler(controller: vscode.TestController, r
254253
const isClientSideMode = controller.id === `${extensionId}-Local`;
255254
const isDebug = request.profile?.kind === vscode.TestRunProfileKind.Debug;
256255
const runQualifiers = !isClientSideMode ? "/noload/nodelete" : isDebug ? "/noload" : "";
257-
let userParam = vscode.workspace.getConfiguration('objectscript', oneUri).get<boolean>('multilineMethodArgs', false) ? 1 : 0;
256+
const userParam = vscode.workspace.getConfiguration('objectscript', oneUri).get<boolean>('multilineMethodArgs', false) ? 1 : 0;
258257
const runIndex = allTestRuns.push(run) - 1;
259258
runIndices.push(runIndex);
260259

@@ -271,7 +270,7 @@ export async function commonRunTestsHandler(controller: vscode.TestController, r
271270

272271
let program = `##class(vscode.dc.testingmanager.StandardManager).RunTest("${testSpec}","${runQualifiers}",${userParam})`;
273272
if (coverageRequest) {
274-
program = `##class(${UTIL_CLASSNAME}).${SQL_FN_RUNTESTPROXY}("${testSpec}","${runQualifiers}",2)`;
273+
program = `##class(vscode.dc.testingmanager.CoverageManager).RunTest("${testSpec}","${runQualifiers}",${userParam})`
275274
request.profile.loadDetailedCoverage = async (_testRun, fileCoverage, _token) => {
276275
return fileCoverage instanceof OurFileCoverage ? fileCoverage.loadDetailedCoverage() : [];
277276
};

0 commit comments

Comments
 (0)