Skip to content

Commit 1a1488c

Browse files
fix(remote-config): incorrect if condition & doc update (#6892)
1 parent e1504aa commit 1a1488c

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

packages/remote-config/lib/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ class FirebaseConfigModule extends FirebaseModule {
101101
throw new Error("firebase.remoteConfig().defaultConfig: 'defaults' must be an object.");
102102
}
103103
// To make Firebase web v9 API compatible, we update the config first so it immediately
104-
// updates defaults on the instance. We then pass to web platform to update. We do this because
104+
// updates defaults on the instance. We then pass to underlying SDK to update. We do this because
105105
// there is no way to "await" a setter.
106106
this._updateFromConstants(defaults);
107107
this.setDefaults.call(this, defaults, true);
@@ -113,7 +113,7 @@ class FirebaseConfigModule extends FirebaseModule {
113113

114114
set settings(settings) {
115115
// To make Firebase web v9 API compatible, we update the settings first so it immediately
116-
// updates settings on the instance. We then pass to web platform to update. We do this because
116+
// updates settings on the instance. We then pass to underlying SDK to update. We do this because
117117
// there is no way to "await" a setter. We can't delegate to `setConfigSettings()` as it is setup
118118
// for native.
119119
this._updateFromConstants(settings);
@@ -176,7 +176,7 @@ class FirebaseConfigModule extends FirebaseModule {
176176

177177
setConfigSettings(settings) {
178178
const updatedSettings = {};
179-
if (!this._isWeb) {
179+
if (this._isWeb) {
180180
updatedSettings.fetchTimeMillis = this._settings.fetchTimeMillis;
181181
updatedSettings.minimumFetchIntervalMillis = this._settings.minimumFetchIntervalMillis;
182182
} else {

0 commit comments

Comments
 (0)