style(lint): yarn lint:android on performance files

mikehardy · mikehardy · commit 51f26d1f88a5 · 2023-02-02T12:24:36.000-05:00
diff --git a/packages/perf/android/src/main/java/io/invertase/firebase/perf/ScreenTrace.java b/packages/perf/android/src/main/java/io/invertase/firebase/perf/ScreenTrace.java
@@ -3,53 +3,48 @@
 /**
  * Copyright 2021 Google Inc. All Rights Reserved.
  *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
+ * <p>Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of the License at
  *
- * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>http://www.apache.org/licenses/LICENSE-2.0
  *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
+ * <p>Unless required by applicable law or agreed to in writing, software distributed under the
+ * License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+ * express or implied. See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 import android.app.Activity;
 import android.os.Build;
 import android.util.Log;
 import android.util.SparseIntArray;
 import android.view.WindowManager;
-
 import androidx.core.app.FrameMetricsAggregator;
-
 import com.google.firebase.perf.FirebasePerformance;
 import com.google.firebase.perf.metrics.Trace;
 import com.google.firebase.perf.util.Constants;
 
 /**
- * Utility class to capture Screen rendering information (Slow/Frozen frames) for the
- * {@code Activity} passed to the constructor {@link io.invertase.firebase.perf.ScreenTrace#ScreenTrace(Activity, String)}.
- * <p>
- * Learn more at https://firebase.google.com/docs/perf-mon/screen-traces?platform=android.
- * <p>
- * A slow screen rendering often leads to a UI Jank which creates a bad user experience. Below are
- * some tips and references to understand and fix common UI Jank issues:
- * - https://developer.android.com/topic/performance/vitals/render.html#fixing_jank
- * - https://youtu.be/CaMTIgxCSqU (Why 60fps?)
- * - https://youtu.be/HXQhu6qfTVU (Rendering Performance)
- * - https://youtu.be/1iaHxmfZGGc (Understanding VSYNC)
- * - https://www.youtube.com/playlist?list=PLOU2XLYxmsIKEOXh5TwZEv89aofHzNCiu (Android Performance Patterns)
- * <p>
- * References:
- * - Fireperf Source Code
+ * Utility class to capture Screen rendering information (Slow/Frozen frames) for the {@code
+ * Activity} passed to the constructor {@link
+ * io.invertase.firebase.perf.ScreenTrace#ScreenTrace(Activity, String)}.
+ *
+ * <p>Learn more at https://firebase.google.com/docs/perf-mon/screen-traces?platform=android.
+ *
+ * <p>A slow screen rendering often leads to a UI Jank which creates a bad user experience. Below
+ * are some tips and references to understand and fix common UI Jank issues: -
+ * https://developer.android.com/topic/performance/vitals/render.html#fixing_jank -
+ * https://youtu.be/CaMTIgxCSqU (Why 60fps?) - https://youtu.be/HXQhu6qfTVU (Rendering Performance)
+ * - https://youtu.be/1iaHxmfZGGc (Understanding VSYNC) -
+ * https://www.youtube.com/playlist?list=PLOU2XLYxmsIKEOXh5TwZEv89aofHzNCiu (Android Performance
+ * Patterns)
+ *
+ * <p>References: - Fireperf Source Code
  */
 public class ScreenTrace {
 
   private static final String TAG = "RNFirebasePerf";
   private static final String FRAME_METRICS_AGGREGATOR_CLASSNAME =
-    "androidx.core.app.FrameMetricsAggregator";
+      "androidx.core.app.FrameMetricsAggregator";
 
   private final Activity activity;
   private final String traceName;
@@ -61,8 +56,8 @@ public class ScreenTrace {
    * Default constructor for this class.
    *
    * @param activity for which the screen traces should be recorded.
-   * @param tag      used as an identifier for the name to be used to log screen rendering
-   *                 information (like "MyFancyScreen").
+   * @param tag used as an identifier for the name to be used to log screen rendering information
+   *     (like "MyFancyScreen").
    * @implNote It requires hardware acceleration to be on or it throws.
    */
   public ScreenTrace(Activity activity, String tag) throws IllegalStateException {
@@ -75,17 +70,17 @@ public ScreenTrace(Activity activity, String tag) throws IllegalStateException {
     boolean isScreenTraceSupported = checkScreenTraceSupport(activity);
 
     if (!isScreenTraceSupported) {
-      throw new IllegalStateException("Device does not support screen traces. Hardware acceleration must be enabled and Android must not be 8.0 or 8.1.");
+      throw new IllegalStateException(
+          "Device does not support screen traces. Hardware acceleration must be enabled and Android"
+              + " must not be 8.0 or 8.1.");
     }
 
     frameMetricsAggregator = new FrameMetricsAggregator();
   }
 
   // region Public APIs
 
-  /**
-   * Starts recording the frame metrics for the screen traces.
-   */
+  /** Starts recording the frame metrics for the screen traces. */
   public void recordScreenTrace() {
     Log.d(TAG, "Recording screen trace " + traceName);
 
@@ -97,7 +92,7 @@ public void recordScreenTrace() {
    * Stops recording screen traces and dispatches the trace capturing information on %age of
    * Slow/Frozen frames.
    *
-   * Inspired by fireperf source.
+   * <p>Inspired by fireperf source.
    */
   public void sendScreenTrace() {
     if (perfScreenTrace == null) return;
@@ -143,12 +138,20 @@ public void sendScreenTrace() {
       perfScreenTrace.putMetric(Constants.CounterNames.FRAMES_FROZEN.toString(), frozenFrames);
     }
 
-    Log.d(TAG, new StringBuilder()
-      .append("sendScreenTrace ").append(traceName)
-      .append(", name: ").append(getScreenTraceName())
-      .append(", total_frames: ").append(totalFrames)
-      .append(", slow_frames: ").append(slowFrames)
-      .append(", frozen_frames: ").append(frozenFrames).toString());
+    Log.d(
+        TAG,
+        new StringBuilder()
+            .append("sendScreenTrace ")
+            .append(traceName)
+            .append(", name: ")
+            .append(getScreenTraceName())
+            .append(", total_frames: ")
+            .append(totalFrames)
+            .append(", slow_frames: ")
+            .append(slowFrames)
+            .append(", frozen_frames: ")
+            .append(frozenFrames)
+            .toString());
 
     // Stop and record trace
     perfScreenTrace.stop();
@@ -161,17 +164,30 @@ public void sendScreenTrace() {
   private static boolean checkScreenTraceSupport(Activity activity) {
     boolean isValidSDKVersion = checkSDKVersion();
     boolean hasFrameMetricsAggregatorClass = checkFrameMetricsAggregatorClass();
-    boolean isActivityHardwareAccelerated = activity.getWindow() != null
-      && ((activity.getWindow().getAttributes().flags & WindowManager.LayoutParams.FLAG_HARDWARE_ACCELERATED) != 0);
-
-
-    boolean supported = isValidSDKVersion && hasFrameMetricsAggregatorClass && isActivityHardwareAccelerated;
-
-    Log.d(TAG, new StringBuilder()
-      .append("isValidSDKVersion: ").append(isValidSDKVersion)
-      .append("isScreenTraceSupported(").append(activity).append("): ").append(supported)
-      .append(" [hasFrameMetricsAggregatorClass: ").append(hasFrameMetricsAggregatorClass)
-      .append(", isActivityHardwareAccelerated: ").append(isActivityHardwareAccelerated).append("]").toString());
+    boolean isActivityHardwareAccelerated =
+        activity.getWindow() != null
+            && ((activity.getWindow().getAttributes().flags
+                    & WindowManager.LayoutParams.FLAG_HARDWARE_ACCELERATED)
+                != 0);
+
+    boolean supported =
+        isValidSDKVersion && hasFrameMetricsAggregatorClass && isActivityHardwareAccelerated;
+
+    Log.d(
+        TAG,
+        new StringBuilder()
+            .append("isValidSDKVersion: ")
+            .append(isValidSDKVersion)
+            .append("isScreenTraceSupported(")
+            .append(activity)
+            .append("): ")
+            .append(supported)
+            .append(" [hasFrameMetricsAggregatorClass: ")
+            .append(hasFrameMetricsAggregatorClass)
+            .append(", isActivityHardwareAccelerated: ")
+            .append(isActivityHardwareAccelerated)
+            .append("]")
+            .toString());
 
     return supported;
   }
@@ -184,9 +200,7 @@ private static boolean checkSDKVersion() {
     return true;
   }
 
-  /**
-   * Inspired by fireperf source.
-   */
+  /** Inspired by fireperf source. */
   private static boolean checkFrameMetricsAggregatorClass() {
     try {
       Class<?> initializerClass = Class.forName(FRAME_METRICS_AGGREGATOR_CLASSNAME);
@@ -196,9 +210,7 @@ private static boolean checkFrameMetricsAggregatorClass() {
     }
   }
 
-  /**
-   * Inspired by fireperf source.
-   */
+  /** Inspired by fireperf source. */
   private String getScreenTraceName() {
     return Constants.SCREEN_TRACE_PREFIX + traceName;
   }
diff --git a/packages/perf/android/src/main/java/io/invertase/firebase/perf/UniversalFirebasePerfModule.java b/packages/perf/android/src/main/java/io/invertase/firebase/perf/UniversalFirebasePerfModule.java
@@ -105,24 +105,24 @@ Task<Void> stopTrace(int id, Bundle metrics, Bundle attributes) {
 
   Task<Void> startScreenTrace(Activity activity, int id, String identifier) {
     return Tasks.call(
-      () -> {
-        ScreenTrace screenTrace = new ScreenTrace(activity, identifier);
-        screenTrace.recordScreenTrace();
-        screenTraces.put(id, screenTrace);
+        () -> {
+          ScreenTrace screenTrace = new ScreenTrace(activity, identifier);
+          screenTrace.recordScreenTrace();
+          screenTraces.put(id, screenTrace);
 
-        return null;
-      });
+          return null;
+        });
   }
 
   Task<Void> stopScreenTrace(int id) {
     return Tasks.call(
-      () -> {
-        ScreenTrace trace = screenTraces.get(id);
-        trace.sendScreenTrace();
-        screenTraces.remove(id);
+        () -> {
+          ScreenTrace trace = screenTraces.get(id);
+          trace.sendScreenTrace();
+          screenTraces.remove(id);
 
-        return null;
-      });
+          return null;
+        });
   }
 
   Task<Void> startHttpMetric(int id, String url, String httpMethod) {
diff --git a/packages/perf/android/src/reactnative/java/io/invertase/firebase/perf/ReactNativeFirebasePerfModule.java b/packages/perf/android/src/reactnative/java/io/invertase/firebase/perf/ReactNativeFirebasePerfModule.java
@@ -97,29 +97,29 @@ public void startScreenTrace(int id, String identifier, Promise promise) {
     }
 
     module
-      .startScreenTrace(currentActivity, id, identifier)
-      .addOnCompleteListener(
-        task -> {
-          if (task.isSuccessful()) {
-            promise.resolve(task.getResult());
-          } else {
-            rejectPromiseWithExceptionMap(promise, task.getException());
-          }
-        });
+        .startScreenTrace(currentActivity, id, identifier)
+        .addOnCompleteListener(
+            task -> {
+              if (task.isSuccessful()) {
+                promise.resolve(task.getResult());
+              } else {
+                rejectPromiseWithExceptionMap(promise, task.getException());
+              }
+            });
   }
 
   @ReactMethod
   public void stopScreenTrace(int id, Promise promise) {
     module
-      .stopScreenTrace(id)
-      .addOnCompleteListener(
-        task -> {
-          if (task.isSuccessful()) {
-            promise.resolve(task.getResult());
-          } else {
-            rejectPromiseWithExceptionMap(promise, task.getException());
-          }
-        });
+        .stopScreenTrace(id)
+        .addOnCompleteListener(
+            task -> {
+              if (task.isSuccessful()) {
+                promise.resolve(task.getResult());
+              } else {
+                rejectPromiseWithExceptionMap(promise, task.getException());
+              }
+            });
   }
 
   @ReactMethod
