Skip to content

Commit d2838a7

Browse files
committed
bump deps + fix lints
fix misreported RMSD unit (is pymtgen cell volume per atom normalized RMSD, not in Å)
1 parent 036b1e1 commit d2838a7

22 files changed

Lines changed: 181 additions & 172 deletions

.pre-commit-config.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ default_install_hook_types: [pre-commit, commit-msg]
44

55
repos:
66
- repo: https://github.com/astral-sh/ruff-pre-commit
7-
rev: v0.15.0
7+
rev: v0.15.6
88
hooks:
99
- id: ruff-check
1010
args: [--fix]
@@ -61,7 +61,7 @@ repos:
6161
pass_filenames: false
6262

6363
- repo: https://github.com/codespell-project/codespell
64-
rev: v2.4.1
64+
rev: v2.4.2
6565
hooks:
6666
- id: codespell
6767
stages: [pre-commit, commit-msg]
@@ -71,7 +71,7 @@ repos:
7171
additional_dependencies: [tomli]
7272

7373
- repo: https://github.com/igorshubovych/markdownlint-cli
74-
rev: v0.47.0
74+
rev: v0.48.0
7575
hooks:
7676
- id: markdownlint
7777
# MD013: line too long
@@ -82,7 +82,7 @@ repos:
8282
exclude: changelog\.md$
8383

8484
- repo: https://github.com/pre-commit/mirrors-eslint
85-
rev: v10.0.0
85+
rev: v10.0.3
8686
hooks:
8787
- id: eslint
8888
types: [file]
@@ -97,7 +97,7 @@ repos:
9797
- '@stylistic/eslint-plugin'
9898

9999
- repo: https://github.com/python-jsonschema/check-jsonschema
100-
rev: 0.36.1
100+
rev: 0.37.0
101101
hooks:
102102
- id: check-jsonschema
103103
files: ^models/.+/.+\.yml$
@@ -108,7 +108,7 @@ repos:
108108
- id: check-github-actions
109109

110110
- repo: https://github.com/crate-ci/typos
111-
rev: v1.43.4
111+
rev: v1.44.0
112112
hooks:
113113
- id: typos
114114
types: [text]

matbench_discovery/metrics/diatomics/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ def write_metrics_to_yaml(
245245
dict[str, str | float | None]: Mean metrics across all elements.
246246
"""
247247
# Calculate mean metrics across all elements
248-
mean_metrics = {
248+
mean_metrics: dict[str, str | float | None] = {
249249
str(metric): float(
250250
f"{np.mean([elem_metrics[metric] for elem_metrics in metrics.values()]):.4}"
251251
)

scripts/evals/geo_opt.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@
134134
points=False,
135135
)
136136
fig_rmsd.layout.xaxis.title = "Model"
137-
fig_rmsd.layout.yaxis.title = "RMSD (Å)"
137+
fig_rmsd.layout.yaxis.title = "RMSD (unitless)"
138138
fig_rmsd.update_traces(orientation="h", side="positive", width=1.8)
139139

140140
# add annotation for mean for each model
@@ -332,16 +332,18 @@
332332
y=sampled_cumulative,
333333
name=f"{model} · {AUC=:.3}",
334334
mode="lines",
335-
hovertemplate=f"<b>{model}</b><br>RMSD: %{{x:.3f}} Å<br>Cumulative: %{{y:.1%}}"
336-
"<extra></extra>",
335+
hovertemplate=(
336+
f"<b>{model}</b><br>RMSD: %{{x:.3f}} (unitless)<br>"
337+
"Cumulative: %{y:.1%}<extra></extra>"
338+
),
337339
)
338340

339341
# sort by AUC
340342
fig_rmsd_cdf.data = sorted(
341343
fig_rmsd_cdf.data, key=lambda trace: -float(trace.name.split("AUC=")[1])
342344
)
343345

344-
fig_rmsd_cdf.layout.xaxis.update(title="RMSD (Å)", range=[0, x_max])
346+
fig_rmsd_cdf.layout.xaxis.update(title="RMSD (unitless)", range=[0, x_max])
345347
fig_rmsd_cdf.layout.yaxis.update(title="Cumulative", tickformat=".0%", range=[0, 1])
346348
fig_rmsd_cdf.layout.legend = dict(y=0, xanchor="right", x=1)
347349

site/package.json

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -25,41 +25,41 @@
2525
},
2626
"devDependencies": {
2727
"@rollup/plugin-yaml": "^4.1.2",
28-
"@stylistic/eslint-plugin": "^5.8.0",
28+
"@stylistic/eslint-plugin": "^5.10.0",
2929
"@sveltejs/adapter-static": "^3.0.10",
30-
"@sveltejs/kit": "^2.51.0",
30+
"@sveltejs/kit": "^2.55.0",
3131
"@sveltejs/vite-plugin-svelte": "^6.2.4",
3232
"@types/d3-array": "^3.2.2",
3333
"@types/d3-scale": "^4.0.9",
3434
"@types/d3-scale-chromatic": "^3.1.0",
3535
"@types/js-yaml": "^4.0.9",
3636
"@types/json-schema": "^7.0.15",
37-
"@types/node": "^25.2.3",
38-
"@vitest/coverage-v8": "^4.0.18",
37+
"@types/node": "^25.5.0",
38+
"@vitest/coverage-v8": "^4.1.0",
3939
"d3-array": "^3.2.4",
4040
"d3-scale": "^4.0.2",
4141
"d3-scale-chromatic": "^3.1.0",
42-
"eslint": "^10.0.0",
43-
"eslint-plugin-svelte": "^3.15.0",
44-
"happy-dom": "^20.6.1",
42+
"eslint": "^10.0.3",
43+
"eslint-plugin-svelte": "^3.15.2",
44+
"happy-dom": "^20.8.4",
4545
"js-yaml": "^4.1.1",
4646
"json-schema-to-typescript": "^15.0.4",
47-
"matterviz": "^0.3.1",
48-
"mdsvex": "^0.12.6",
47+
"matterviz": "^0.3.2",
48+
"mdsvex": "^0.12.7",
4949
"rehype-katex-svelte": "^1.2.0",
5050
"rehype-stringify": "^10.0.1",
5151
"remark-math": "3.0.1",
5252
"remark-parse": "^11.0.0",
5353
"remark-rehype": "^11.1.2",
54-
"svelte": "^5.51.0",
55-
"svelte-check-rs": "^0.9.2",
56-
"svelte-multiselect": "^11.6.1",
54+
"svelte": "^5.53.11",
55+
"svelte-check-rs": "^0.9.5",
56+
"svelte-multiselect": "^11.6.3",
5757
"svelte-preprocess": "^6.0.3",
58-
"svelte-toc": "^0.6.2",
58+
"svelte-toc": "^0.6.3",
5959
"typescript": "5.9.3",
60-
"typescript-eslint": "^8.55.0",
60+
"typescript-eslint": "^8.57.0",
6161
"unified": "^11.0.5",
6262
"vite": "^7.3.1",
63-
"vitest": "^4.0.18"
63+
"vitest": "^4.1.0"
6464
}
6565
}

site/src/app.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,10 @@
7272
--tooltip-bg: var(--surface-bg);
7373
--tooltip-shadow: drop-shadow(0 1px 8px var(--shadow));
7474

75+
--dropdown-bg: var(--page-bg);
76+
--dropdown-color: var(--text-color);
77+
--dropdown-border: var(--border);
78+
7579
--sms-margin: 1em auto;
7680
--sms-border: 1px solid var(--border);
7781
--sms-options-bg: var(--page-bg);

site/src/figs/struct-rmsd-cdf-models.svelte

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)