fix: resolve ESLint errors blocking CI

Fix no-useless-escape, no-undef, prefer-const, and preserve-caught-error
lint errors in validators, bump-version, apex-analysis, and install-config.

Author: jiten-singh-shahi

scripts/ci/validate-agents.js

@@ -151,7 +151,7 @@ function validateAgent(filePath, availableSkills) {
       );
     }
 
-    if (!/do not|don\'t|not for|except|excluding/i.test(desc)) {
+    if (!/do not|don't|not for|except|excluding/i.test(desc)) {
       warn(relPath, 'description missing WHEN NOT clause — add "Do NOT use for [exclusions]"');
     }
   }
@@ -195,8 +195,6 @@ function validateAgent(filePath, availableSkills) {
   const FILE_WRITE_TOOLS = new Set(['write', 'edit', 'multiedit']);
   const readonly = parseBool(frontmatter.readonly);
   const hasFileWriteTools = toolsList.some(t => FILE_WRITE_TOOLS.has(t));
-  const hasDestructiveTools = toolsList.some(t => DESTRUCTIVE_TOOLS.has(t));
-
   if (readonly === true && hasFileWriteTools) {
     const writeTools = toolsList.filter(t => FILE_WRITE_TOOLS.has(t));
     fileErrors.push(
@@ -300,7 +298,7 @@ function validateAgent(filePath, availableSkills) {
     if (readonly !== true) {
       warn(relPath, 'inspector agent should have readonly: true');
     }
-    if (hasWriteTools) {
+    if (hasFileWriteTools) {
       fileErrors.push('inspector agent must not have write tools — inspectors are read-only');
     }
   }

scripts/ci/validate-skills.js

@@ -216,7 +216,7 @@ function validateSkill(skillDir, file) {
       );
     }
 
-    if (!/do not|don\'t|not for|except|excluding/i.test(desc)) {
+    if (!/do not|don't|not for|except|excluding/i.test(desc)) {
       warn(label, 'description missing WHEN NOT clause — add "Do NOT use for [exclusions]"');
     }
   }

scripts/dev/bump-version.js

@@ -52,7 +52,7 @@ function updateFile(filePath, oldVersion, newVersion) {
   const fullPath = path.join(ROOT, filePath);
   if (!fs.existsSync(fullPath)) return false;
 
-  let content = fs.readFileSync(fullPath, 'utf8');
+  const content = fs.readFileSync(fullPath, 'utf8');
   const updated = content.replace(
     new RegExp(`"version":\\s*"${oldVersion.replace(/\./g, '\\.')}"`, 'g'),
     `"version": "${newVersion}"`

scripts/lib/apex-analysis.js

@@ -74,7 +74,7 @@ function isTestClass(code) {
 function trackLoopDepth(processedLines) {
   const depths = [];
   let globalBraceDepth = 0;   // total brace depth in file
-  let activeLoopDepths = [];   // stack: globalBraceDepth where each braced loop started
+  const activeLoopDepths = [];   // stack: globalBraceDepth where each braced loop started
   let unbracedStack = 0;       // counter for nested unbraced loops
   let parenDepth = 0;          // for multi-line for/while declarations
   let pendingLoop = false;     // SCANNING_DECLARATION state

scripts/lib/install-config.js

@@ -51,7 +51,7 @@ function loadInstallConfig(configPath) {
   try {
     raw = JSON.parse(fs.readFileSync(resolved, 'utf8'));
   } catch (err) {
-    throw new Error(`Invalid JSON in config ${resolved}: ${err.message}`);
+    throw new Error(`Invalid JSON in config ${resolved}: ${err.message}`, { cause: err });
   }
 
   // Validate against schema