chore: add install smoke test job to CI pipeline (#9)

jiten-singh-shahi · web-flow · commit d24a466297de · 2026-04-01T14:59:20.000-04:00
* feat: add install smoke test job to CI pipeline

Test npm pack, CLI commands, and install/uninstall flows for apex, lwc,
and all profiles. Verifies correct files are installed per profile and
extended content is excluded from non-full installs.

* fix: fix smoke test and document local testing workflow

Remove dev-only commands (doctor, status, plan, list-installed) from
smoke test — they are not in npm package files field. Add local smoke
test script (scripts/ci/smoke-test.sh). Document in CLAUDE.md and
README.md.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -45,3 +45,200 @@ jobs:
 
       - name: Skills health check
         run: node scripts/dev/skills-health.js
+
+  install-smoke-test:
+    runs-on: ubuntu-latest
+    needs: build-and-test
+    strategy:
+      matrix:
+        node-version: [20]
+
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Setup Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v6
+        with:
+          node-version: ${{ matrix.node-version }}
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Build
+        run: npm run build
+
+      # ── Pack tarball (simulates npm publish) ──────────────────────────
+      - name: Create npm tarball
+        run: |
+          npm pack
+          echo "TARBALL=$(ls scc-universal-*.tgz)" >> $GITHUB_ENV
+
+      - name: Verify tarball exists and is non-empty
+        run: |
+          test -f "$TARBALL"
+          SIZE=$(stat --format=%s "$TARBALL")
+          echo "Tarball size: ${SIZE} bytes"
+          test "$SIZE" -gt 100000  # Must be > 100KB
+
+      # ── CLI help and version ──────────────────────────────────────────
+      - name: Test CLI --help
+        run: |
+          node scripts/scc.js --help 2>&1 | grep -q "SCC — Salesforce Claude Code CLI"
+
+      - name: Test CLI --version
+        run: |
+          VERSION=$(node scripts/scc.js --version 2>&1)
+          echo "Version output: $VERSION"
+          echo "$VERSION" | grep -qE "^[0-9]+\.[0-9]+\.[0-9]+"
+
+      # ── Create dummy Salesforce project ───────────────────────────────
+      - name: Create test project
+        run: |
+          mkdir -p /tmp/test-project/force-app/main/default/classes
+          echo '{ "packageDirectories": [{ "path": "force-app", "default": true }] }' > /tmp/test-project/sfdx-project.json
+
+      # ── Install from tarball into test project ────────────────────────
+      - name: Install tarball into test project
+        run: |
+          cd /tmp/test-project
+          npm init -y > /dev/null 2>&1
+          npm install "$GITHUB_WORKSPACE/$TARBALL"
+
+      # ── Test: scc install apex ────────────────────────────────────────
+      - name: Test scc install apex
+        run: |
+          cd /tmp/test-project
+          npx scc install apex
+
+      - name: Verify apex install — core agents
+        run: |
+          test -f /tmp/test-project/.claude/agents/sf-blueprint-planner.md
+          test -f /tmp/test-project/.claude/agents/sf-code-reviewer.md
+          test -f /tmp/test-project/.claude/agents/sf-tdd-guide.md
+
+      - name: Verify apex install — apex agents
+        run: |
+          test -f /tmp/test-project/.claude/agents/sf-apex-reviewer.md
+          test -f /tmp/test-project/.claude/agents/sf-trigger-architect.md
+          test -f /tmp/test-project/.claude/agents/sf-performance-optimizer.md
+
+      - name: Verify apex install — security agent
+        run: |
+          test -f /tmp/test-project/.claude/agents/sf-security-reviewer.md
+
+      - name: Verify apex install — devops agent
+        run: |
+          test -f /tmp/test-project/.claude/agents/sf-devops-deployment.md
+
+      - name: Verify apex install — core skills
+        run: |
+          test -f /tmp/test-project/.claude/skills/sf-help/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-quickstart/SKILL.md
+          test -f /tmp/test-project/.claude/skills/model-route/SKILL.md
+
+      - name: Verify apex install — apex skills
+        run: |
+          test -f /tmp/test-project/.claude/skills/sf-trigger-frameworks/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-apex-async-patterns/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-apex-testing/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-apex-best-practices/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-apex-constraints/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-soql-constraints/SKILL.md
+
+      - name: Verify apex install — security skills
+        run: |
+          test -f /tmp/test-project/.claude/skills/sf-security/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-governor-limits/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-soql-optimization/SKILL.md
+
+      - name: Verify apex install — devops skills
+        run: |
+          test -f /tmp/test-project/.claude/skills/sf-deployment/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-deployment-constraints/SKILL.md
+
+      - name: Verify apex install — hooks
+        run: |
+          test -f /tmp/test-project/.claude/hooks/hooks.json
+
+      - name: Verify apex install — reference files
+        run: |
+          test -d /tmp/test-project/.claude/skills/_reference
+          test -f /tmp/test-project/.claude/skills/_reference/GOVERNOR_LIMITS.md
+
+      - name: Verify apex install — NO extended content (should not be installed)
+        run: |
+          test ! -f /tmp/test-project/.claude/agents/sf-agentforce-builder.md
+          test ! -f /tmp/test-project/.claude/agents/sf-flow-reviewer.md
+          test ! -f /tmp/test-project/.claude/skills/sf-flow-development/SKILL.md
+
+      # ── Test: scc uninstall ───────────────────────────────────────────
+      - name: Test scc uninstall
+        run: |
+          cd /tmp/test-project
+          npx scc uninstall --yes
+
+      - name: Verify uninstall removed files
+        run: |
+          test ! -f /tmp/test-project/.claude/agents/sf-apex-reviewer.md
+          test ! -f /tmp/test-project/.claude/skills/sf-apex-testing/SKILL.md
+
+      # ── Test: scc install all (full profile) ──────────────────────────
+      - name: Test scc install all
+        run: |
+          cd /tmp/test-project
+          npx scc install all
+
+      - name: Verify full install — extended agents present
+        run: |
+          test -f /tmp/test-project/.claude/agents/sf-agentforce-builder.md
+          test -f /tmp/test-project/.claude/agents/sf-flow-reviewer.md
+          test -f /tmp/test-project/.claude/agents/sf-visualforce-reviewer.md
+          test -f /tmp/test-project/.claude/agents/sf-aura-reviewer.md
+          test -f /tmp/test-project/.claude/agents/sf-admin.md
+
+      - name: Verify full install — extended skills present
+        run: |
+          test -f /tmp/test-project/.claude/skills/sf-flow-development/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-agentforce-development/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-visualforce-development/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-aura-development/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-experience-cloud/SKILL.md
+
+      - name: Verify full install — platform agents present
+        run: |
+          test -f /tmp/test-project/.claude/agents/deep-researcher.md
+          test -f /tmp/test-project/.claude/agents/sf-integration-architect.md
+          test -f /tmp/test-project/.claude/agents/sf-build-resolver.md
+
+      - name: Verify full install — platform skills present
+        run: |
+          test -f /tmp/test-project/.claude/skills/sf-apex-cursor/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-data-modeling/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-debugging/SKILL.md
+
+      # ── Test: scc install lwc (after clean uninstall) ─────────────────
+      - name: Clean uninstall before lwc test
+        run: |
+          cd /tmp/test-project
+          npx scc uninstall --yes
+
+      - name: Test scc install lwc
+        run: |
+          cd /tmp/test-project
+          npx scc install lwc
+
+      - name: Verify lwc install — lwc agent and skills present
+        run: |
+          test -f /tmp/test-project/.claude/agents/sf-lwc-reviewer.md
+          test -f /tmp/test-project/.claude/skills/sf-lwc-development/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-lwc-testing/SKILL.md
+          test -f /tmp/test-project/.claude/skills/sf-lwc-constraints/SKILL.md
+
+      - name: Verify lwc install — NO apex-specific agents
+        run: |
+          test ! -f /tmp/test-project/.claude/agents/sf-apex-reviewer.md
+          test ! -f /tmp/test-project/.claude/agents/sf-trigger-architect.md
+
+      # ── Summary ───────────────────────────────────────────────────────
+      - name: Smoke test passed
+        run: echo "All install smoke tests passed successfully"
diff --git a/CLAUDE.md b/CLAUDE.md
@@ -44,6 +44,9 @@ npx markdownlint '**/*.md' --ignore node_modules --fix
 # Coverage (80% lines/functions/branches/statements required)
 npm run coverage
 
+# Smoke test (tests npm pack + install/uninstall in a temp project)
+bash scripts/ci/smoke-test.sh
+
 # SCC CLI
 npx scc install <target>     # Install SCC content (apex, lwc, all)
 npx scc doctor               # Diagnose missing/drifted files
diff --git a/README.md b/README.md
@@ -487,7 +487,9 @@ Contributions are welcome! Please follow these guidelines:
 git clone <repo>
 cd salesforce-claude-code
 npm install
-npm test
+git config core.hooksPath .githooks   # Enable pre-commit checks
+npm test                               # Build + lint + validate + tests
+bash scripts/ci/smoke-test.sh          # Pack + install/uninstall smoke test
 ```
 
 ---
diff --git a/scripts/ci/smoke-test.sh b/scripts/ci/smoke-test.sh
@@ -0,0 +1,170 @@
+#!/usr/bin/env bash
+# Local smoke test — mirrors the CI install-smoke-test job.
+# Run from repo root: bash scripts/ci/smoke-test.sh
+set -euo pipefail
+
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+CYAN='\033[0;36m'
+NC='\033[0m'
+
+PASS=0
+FAIL=0
+TEST_DIR=$(mktemp -d)
+
+pass() { echo -e "  ${GREEN}PASS${NC}  $1"; PASS=$((PASS + 1)); }
+fail() { echo -e "  ${RED}FAIL${NC}  $1"; FAIL=$((FAIL + 1)); }
+section() { echo -e "\n${CYAN}── $1 ──${NC}"; }
+
+cleanup() {
+  rm -rf "$TEST_DIR"
+  rm -f scc-universal-*.tgz
+}
+trap cleanup EXIT
+
+REPO_ROOT="$(cd "$(dirname "$0")/../.." && pwd)"
+cd "$REPO_ROOT"
+
+# ── Pack ────────────────────────────────────────────────────────────────────
+section "npm pack"
+
+npm pack --quiet > /dev/null 2>&1
+TARBALL=$(ls scc-universal-*.tgz 2>/dev/null | head -1)
+
+if [ -n "$TARBALL" ] && [ -f "$TARBALL" ]; then
+  SIZE=$(stat -f%z "$TARBALL" 2>/dev/null || stat --format=%s "$TARBALL" 2>/dev/null)
+  if [ "$SIZE" -gt 100000 ]; then
+    pass "tarball created (${SIZE} bytes)"
+  else
+    fail "tarball too small (${SIZE} bytes)"
+  fi
+else
+  fail "tarball not created"
+fi
+
+# ── CLI help & version ──────────────────────────────────────────────────────
+section "CLI commands"
+
+if node scripts/scc.js --help 2>&1 | grep -q "SCC — Salesforce Claude Code CLI"; then
+  pass "scc --help"
+else
+  fail "scc --help"
+fi
+
+if node scripts/scc.js --version 2>&1 | grep -qE "^[0-9]+\.[0-9]+\.[0-9]+"; then
+  pass "scc --version"
+else
+  fail "scc --version"
+fi
+
+# ── Create test project ────────────────────────────────────────────────────
+section "Setup test project"
+
+mkdir -p "$TEST_DIR/force-app/main/default/classes"
+echo '{ "packageDirectories": [{ "path": "force-app", "default": true }] }' > "$TEST_DIR/sfdx-project.json"
+cd "$TEST_DIR"
+npm init -y > /dev/null 2>&1
+npm install "$REPO_ROOT/$TARBALL" > /dev/null 2>&1
+pass "test project created and tarball installed"
+
+# ── Install apex ────────────────────────────────────────────────────────────
+section "scc install apex"
+
+npx scc install apex > /dev/null 2>&1
+
+# Core agents
+for f in sf-blueprint-planner.md sf-code-reviewer.md sf-tdd-guide.md; do
+  if [ -f ".claude/agents/$f" ]; then pass "core agent: $f"; else fail "core agent: $f"; fi
+done
+
+# Apex agents
+for f in sf-apex-reviewer.md sf-trigger-architect.md sf-performance-optimizer.md; do
+  if [ -f ".claude/agents/$f" ]; then pass "apex agent: $f"; else fail "apex agent: $f"; fi
+done
+
+# Security + devops agents
+if [ -f ".claude/agents/sf-security-reviewer.md" ]; then pass "security agent"; else fail "security agent"; fi
+if [ -f ".claude/agents/sf-devops-deployment.md" ]; then pass "devops agent"; else fail "devops agent"; fi
+
+# Core skills
+for f in sf-help sf-quickstart model-route; do
+  if [ -f ".claude/skills/$f/SKILL.md" ]; then pass "core skill: $f"; else fail "core skill: $f"; fi
+done
+
+# Apex skills
+for f in sf-trigger-frameworks sf-apex-async-patterns sf-apex-testing sf-apex-best-practices sf-apex-constraints sf-soql-constraints; do
+  if [ -f ".claude/skills/$f/SKILL.md" ]; then pass "apex skill: $f"; else fail "apex skill: $f"; fi
+done
+
+# Security skills
+for f in sf-security sf-governor-limits sf-soql-optimization; do
+  if [ -f ".claude/skills/$f/SKILL.md" ]; then pass "security skill: $f"; else fail "security skill: $f"; fi
+done
+
+# Devops skills
+for f in sf-deployment sf-deployment-constraints; do
+  if [ -f ".claude/skills/$f/SKILL.md" ]; then pass "devops skill: $f"; else fail "devops skill: $f"; fi
+done
+
+# Hooks
+if [ -f ".claude/hooks/hooks.json" ]; then pass "hooks installed"; else fail "hooks installed"; fi
+
+# Reference files
+if [ -d ".claude/skills/_reference" ]; then pass "reference dir exists"; else fail "reference dir exists"; fi
+
+# Negative: no extended content
+if [ ! -f ".claude/agents/sf-agentforce-builder.md" ]; then pass "no extended agent (correct)"; else fail "extended agent leaked into apex profile"; fi
+if [ ! -f ".claude/skills/sf-flow-development/SKILL.md" ]; then pass "no extended skill (correct)"; else fail "extended skill leaked into apex profile"; fi
+
+# ── Uninstall ───────────────────────────────────────────────────────────────
+section "scc uninstall"
+
+npx scc uninstall --yes > /dev/null 2>&1
+
+if [ ! -f ".claude/agents/sf-apex-reviewer.md" ]; then pass "uninstall removed agents"; else fail "uninstall did not remove agents"; fi
+if [ ! -f ".claude/skills/sf-apex-testing/SKILL.md" ]; then pass "uninstall removed skills"; else fail "uninstall did not remove skills"; fi
+
+# ── Install all ─────────────────────────────────────────────────────────────
+section "scc install all"
+
+npx scc install all > /dev/null 2>&1
+
+# Extended agents
+for f in sf-agentforce-builder.md sf-flow-reviewer.md sf-visualforce-reviewer.md sf-aura-reviewer.md sf-admin.md; do
+  if [ -f ".claude/agents/$f" ]; then pass "extended agent: $f"; else fail "extended agent: $f"; fi
+done
+
+# Extended skills
+for f in sf-flow-development sf-agentforce-development sf-visualforce-development sf-aura-development sf-experience-cloud; do
+  if [ -f ".claude/skills/$f/SKILL.md" ]; then pass "extended skill: $f"; else fail "extended skill: $f"; fi
+done
+
+# Platform agents
+for f in deep-researcher.md sf-integration-architect.md sf-build-resolver.md; do
+  if [ -f ".claude/agents/$f" ]; then pass "platform agent: $f"; else fail "platform agent: $f"; fi
+done
+
+# ── Install lwc (after clean) ──────────────────────────────────────────────
+section "scc install lwc"
+
+npx scc uninstall --yes > /dev/null 2>&1
+npx scc install lwc > /dev/null 2>&1
+
+if [ -f ".claude/agents/sf-lwc-reviewer.md" ]; then pass "lwc agent"; else fail "lwc agent"; fi
+for f in sf-lwc-development sf-lwc-testing sf-lwc-constraints; do
+  if [ -f ".claude/skills/$f/SKILL.md" ]; then pass "lwc skill: $f"; else fail "lwc skill: $f"; fi
+done
+
+# Negative: no apex agents in lwc profile
+if [ ! -f ".claude/agents/sf-apex-reviewer.md" ]; then pass "no apex agent in lwc (correct)"; else fail "apex agent leaked into lwc profile"; fi
+if [ ! -f ".claude/agents/sf-trigger-architect.md" ]; then pass "no trigger agent in lwc (correct)"; else fail "trigger agent leaked into lwc profile"; fi
+
+# ── Summary ─────────────────────────────────────────────────────────────────
+echo ""
+echo "════════════════════════════════════════════════════════"
+echo -e "Results: ${GREEN}${PASS} passed${NC}, ${RED}${FAIL} failed${NC} ($((PASS + FAIL)) total)"
+echo "════════════════════════════════════════════════════════"
+
+if [ "$FAIL" -gt 0 ]; then
+  exit 1
+fi
