Merge pull request github#907 from smowton/smowton/fix/same-source-perf

lcartey · web-flow · commit 42985d78e147 · 2025-06-06T10:34:30.000Z
Fix poor performance of sameSource predicate
diff --git a/change_notes/2025-06-06-same-source-performance.md b/change_notes/2025-06-06-same-source-performance.md
@@ -0,0 +1,2 @@
+ - `FIO39-C`, `FIO50-CPP`, `A27-0-3`, `RULE-30-0-2`: `IOFstreamMissingPositioning.ql`, `InterleavedInputOutputWithoutPosition.ql`, `InterleavedInputOutputWithoutFlush.ql`, `ReadsAndWritesOnStreamNotSeparatedByPositioning.ql`.
+   - Improved performance for codebases with large numbers of stream or file accesses.
diff --git a/cpp/common/src/codingstandards/cpp/rules/iofstreammissingpositioning/IOFstreamMissingPositioning.qll b/cpp/common/src/codingstandards/cpp/rules/iofstreammissingpositioning/IOFstreamMissingPositioning.qll
@@ -51,7 +51,8 @@ class WriteFunctionCall extends ReadWriteCall {
   }
 }
 
-pragma[inline]
+bindingset[a, b]
+pragma[inline_late]
 predicate sameSource(FunctionCall a, FunctionCall b) {
   sameStreamSource(a, b) or
   sameFileSource(a, b)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+ - `FIO39-C`, `FIO50-CPP`, `A27-0-3`, `RULE-30-0-2`: `IOFstreamMissingPositioning.ql`, `InterleavedInputOutputWithoutPosition.ql`, `InterleavedInputOutputWithoutFlush.ql`, `ReadsAndWritesOnStreamNotSeparatedByPositioning.ql`.
	`2`	`+ - Improved performance for codebases with large numbers of stream or file accesses.`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,8 @@ class WriteFunctionCall extends ReadWriteCall {`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`
`54`		`-pragma[inline]`
	`54`	`+bindingset[a, b]`
	`55`	`+pragma[inline_late]`
`55`	`56`	`predicate sameSource(FunctionCall a, FunctionCall b) {`
`56`	`57`	`sameStreamSource(a, b) or`
`57`	`58`	`sameFileSource(a, b)`